1312980 - CID 1374148: Control flow issues (DEADCODE) in GetUserMediaCallbackMediaStreamListener::NotifyChromeOfTrackStops()

Status: RESOLVED DUPLICATE of bug 1312332

(Core :: WebRTC, defect)

Description

[James Cheng[:JamesCheng]]

*** CID 1374148:  Control flow issues  (DEADCODE)
/dom/media/MediaManager.cpp: 3640 in mozilla::GetUserMediaCallbackMediaStreamListener::NotifyChromeOfTrackStops()()
3634         return;
3635       }
3636
3637       mAudioStopped |= stopAudio;
3638       mVideoStopped |= stopVideo;
3639
>>>     CID 1374148:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "this->mAudioDevice.get()" inside this statement: "<storage from new>->MediaOp...".
3640       RefPtr<MediaOperationTask> mediaOperation =
3641         new MediaOperationTask(MEDIA_STOP_TRACK,
3642                                this, nullptr, nullptr,
3643                                stopAudio ? mAudioDevice.get() : nullptr,
3644                                stopVideo ? mVideoDevice.get() : nullptr,
3645                                false , mWindowID, nullptr);


Indicating that the mAudioDevice.get() will never be invoked due to stopAudio = false;

But I suspect the statement[1] is a bug.

[1]
http://searchfox.org/mozilla-central/rev/e3e8571c5378ac92663d4f583ccc4ad0a3019716/dom/media/MediaManager.cpp#3631

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1312980 - CID 1374148: Control flow issues (DEADCODE) in GetUserMediaCallbackMediaStreamListener::NotifyChromeOfTrackStops()

Review commit: https://reviewboard.mozilla.org/r/88484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88484/

Comment 2

[James Cheng[:JamesCheng]]

Hi Andreas,

Do you think it is a bug by comment 0?

Comment 3

[Andreas Pehrson [:pehrsons]]

Absolutely right! Though a fix is already on the way :-)

Comment 4

[James Cheng[:JamesCheng]]

Thank you,  cancel the review request!