Port bug 1312991 |Get rid of nsIHTMLEditor.setDocumentTitle()| to TB and SM

RESOLVED FIXED in Thunderbird 53.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
7 months ago
5 months ago

People

(Reporter: Jorg K (GMT+2), Assigned: Jorg K (GMT+2))

Tracking

Trunk
Thunderbird 53.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 months ago
+++ This bug was initially created as a clone of Bug #1312991 +++

Replace
  GetCurrentEditor().setDocumentTitle(title);
with
  GetCurrentEditorElement().ownerDocument.title = title;
  or
  getBrowser().contentDocument.title = title;

Since getBrowser() has become more famous these days, I prefer the latter.
(Assignee)

Comment 1

7 months ago
Created attachment 8804772 [details] [diff] [review]
1313033.patch

Notes:
I prefer to use getBrowser().contentDocument, so that's what I've used in TB. Editor and SM don't have getBrowser(), so there it's GetCurrentEditorElement().contentDocument. GetCurrentEditorElement().ownerDocument as suggested in comment #0 is not correct.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8804772 - Flags: review?(iann_bugzilla)
Attachment #8804772 - Flags: review?(acelists)

Comment 2

7 months ago
I would like to use the same command for all 3 versions while it works. So GetCurrentEditorElement().contentDocument also for /mail .
(Assignee)

Comment 3

7 months ago
Created attachment 8807054 [details] [diff] [review]
1313033.patch (v2)
Attachment #8804772 - Attachment is obsolete: true
Attachment #8804772 - Flags: review?(iann_bugzilla)
Attachment #8804772 - Flags: review?(acelists)
Attachment #8807054 - Flags: review?(iann_bugzilla)
Attachment #8807054 - Flags: review?(acelists)

Comment 4

7 months ago
Comment on attachment 8807054 [details] [diff] [review]
1313033.patch (v2)

Review of attachment 8807054 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8807054 - Flags: review?(acelists) → review+

Comment 5

5 months ago
Comment on attachment 8807054 [details] [diff] [review]
1313033.patch (v2)

r/a=me
Attachment #8807054 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 6

5 months ago
https://hg.mozilla.org/comm-central/rev/9fa9c0c8bbe105fb574a7e9be18c0af0de743f7f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.