1313033 - Port bug 1312991 |Get rid of nsIHTMLEditor.setDocumentTitle()| to TB and SM

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1312991 +++

Replace
  GetCurrentEditor().setDocumentTitle(title);
with
  GetCurrentEditorElement().ownerDocument.title = title;
  or
  getBrowser().contentDocument.title = title;

Since getBrowser() has become more famous these days, I prefer the latter.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1313033.patch

Notes:
I prefer to use getBrowser().contentDocument, so that's what I've used in TB. Editor and SM don't have getBrowser(), so there it's GetCurrentEditorElement().contentDocument. GetCurrentEditorElement().ownerDocument as suggested in comment #0 is not correct.

Comment 2

[:aceman]

I would like to use the same command for all 3 versions while it works. So GetCurrentEditorElement().contentDocument also for /mail .

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1313033.patch (v2)

Comment 4

[:aceman]

Comment on attachment 8807054 [details] [diff] [review]
1313033.patch (v2)

Review of attachment 8807054 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 5

[Ian Neal]

Comment on attachment 8807054 [details] [diff] [review]
1313033.patch (v2)

r/a=me

Comment 6

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/9fa9c0c8bbe105fb574a7e9be18c0af0de743f7f