Fix setelem check in SetObjectElementOperation

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Posted patch PatchSplinter Review
This fixes the perf issue André described in bug 1291463 comment 0.

Regression from bug 1101905 so this is pretty old.
Attachment #8804653 - Flags: review?(andrebargull)
Comment on attachment 8804653 [details] [diff] [review]
Patch

Review of attachment 8804653 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, that was simple. :-)
Attachment #8804653 - Flags: review?(andrebargull) → review+

Comment 2

3 years ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2f850fe57e1
Fix SETELEM check in SetObjectElementOperation to check for the strict version too. r=anba

Comment 3

3 years ago
It seems either this bug or bug 1313036 improved Octane-Gameboy a little.

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d2f850fe57e1
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Depends on: 1383591
Assignee

Updated

2 years ago
No longer depends on: 1383591
You need to log in before you can comment on or make changes to this bug.