Text is more truncated with ellipsis in datalist for input

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
Autocomplete
P1
normal
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: blinky, Assigned: mconley)

Tracking

({regression})

52 Branch
mozilla52
x86_64
Windows 7
regression
Points:
---

Firefox Tracking Flags

(firefox49 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

6 months ago
Steps to reproduce:

1. Go to https://dl.dropboxusercontent.com/u/95157096/85f61cf7/phacpjwi7i.html.
2. Click on the <input> element to open.


Actual results:

Text is more truncated with ellipsis in datalist for input.

Screenshot https://dl.dropboxusercontent.com/u/95157096/85f61cf7/fe9mwb3fst.png
(Reporter)

Comment 1

6 months ago
Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cf7649531c81d88c1948c88512b0c8c50cf0f2e3&tochange=4b2fef1aa33e310f577dbe36a6c6abf3f1c7f0ce

Regressed by: bug 1296638
Blocks: 1296638
Keywords: regression
(Reporter)

Updated

6 months ago
Flags: needinfo?(mconley)
(Reporter)

Updated

6 months ago
tracking-firefox52: --- → ?

Updated

6 months ago
status-firefox49: --- → unaffected
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → affected
Created attachment 8805596 [details]
Test case
Thanks. It looks like the richlist autocomplete binding has some hard-coded extra padding at the end of each richlistitem.

I'll make that opt-in on the binding.
Flags: needinfo?(mconley)
Assignee: nobody → mconley
Comment hidden (mozreview-request)
Attachment #8805602 - Flags: review?(MattN+bmo) → review?(mak77)

Comment 5

6 months ago
mozreview-review
Comment on attachment 8805602 [details]
Bug 1313067 - Make extra padding in autocomplete popup richlistitem opt-in.

https://reviewboard.mozilla.org/r/89354/#review90090

::: browser/base/content/browser.xul:156
(Diff revision 1)
>             id="PopupAutoCompleteRichResult"
>             noautofocus="true"
>             hidden="true"
>             flip="none"
> -           level="parent"/>
> +           level="parent"
> +           extrapadding="true" />

ah, I didn't remember of this, my memory gets rusty.

What about naming this overflowpadding and making it a numeric value rather than a boolean, so:
overflowpadding="30"

::: toolkit/content/widgets/autocomplete.xml:1411
(Diff revision 1)
>            ]]>
>          </setter>
>        </property>
>  
> +      <property name="useExtraPadding"
> +                onget="return this.getAttribute('extrapadding') == 'true';"

and here you could return 0 as the default value, so below you can just use popup.overflowPadding in the calculation and avoid assigning to a pointless extraPadding temp var.

using Number(...getAttribute()) may do the trick (empty string is handled as 0).
Attachment #8805602 - Flags: review?(mak77)
Comment hidden (mozreview-request)

Comment 7

6 months ago
mozreview-review
Comment on attachment 8805602 [details]
Bug 1313067 - Make extra padding in autocomplete popup richlistitem opt-in.

https://reviewboard.mozilla.org/r/89354/#review90144
Attachment #8805602 - Flags: review?(mak77) → review+

Comment 8

6 months ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b30232f430a
Make extra padding in autocomplete popup richlistitem opt-in. r=mak
(Reporter)

Updated

6 months ago
tracking-firefox52: ? → ---

Updated

6 months ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4b30232f430a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.