1313106 - Many duplicate files in Firefox branding & theme

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P5)

Description

[Chris AtLee [:catlee]]

See for example in the log from today's nightly:
https://archive.mozilla.org/pub/firefox/nightly/2016/10/2016-10-26-03-02-10-mozilla-central/mozilla-central-win64-nightly-bm94-build1-build0.txt.gz

It looks like there are some resources shared between the theme and devtools. Devtools reduction is happening in bug 1311178.

05:27:27     INFO -  Duplicates 805 bytes:
05:27:27     INFO -    browser/chrome/browser/skin/classic/browser/controlcenter/warning-gray.svg
05:27:27     INFO -    browser/chrome/devtools/skin/images/security-state-broken.svg
05:27:27     INFO -  Duplicates 931 bytes:
05:27:27     INFO -    browser/chrome/browser/skin/classic/browser/newtab/close.png
05:27:27     INFO -    chrome/toolkit/skin/classic/global/icons/close-XPVista7.png
05:27:27     INFO -  Duplicates 1121 bytes:
05:27:27     INFO -    browser/chrome/browser/skin/classic/browser/connection-secure.svg
05:27:27     INFO -    browser/chrome/devtools/skin/images/security-state-secure.svg
05:27:27     INFO -  Duplicates 1397 bytes:
05:27:27     INFO -    browser/chrome/browser/content/browser/extension.svg
05:27:27     INFO -    browser/chrome/browser/skin/classic/browser/addons/addon-install-confirm.svg
05:27:27     INFO -  Duplicates 1766 bytes:
05:27:27     INFO -    browser/chrome/browser/content/browser/places/bookmarkProperties.xul
05:27:27     INFO -    browser/chrome/browser/content/browser/places/bookmarkProperties2.xul
05:27:27     INFO -  Duplicates 2084 bytes:
05:27:27     INFO -    browser/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/icon.png
05:27:27     INFO -    browser/chrome/browser/skin/classic/browser/theme-switcher-icon.png
05:27:27     INFO -  Duplicates 3243 bytes:
05:27:27     INFO -    chrome/toolkit/skin/classic/mozapps/downloads/downloadButtons-XP.png
05:27:27     INFO -    chrome/toolkit/skin/classic/mozapps/update/downloadButtons-XP.png
05:27:27     INFO -  Duplicates 5148 bytes:
05:27:27     INFO -    chrome/toolkit/skin/classic/mozapps/downloads/downloadButtons.png
05:27:27     INFO -    chrome/toolkit/skin/classic/mozapps/update/downloadButtons.png
05:27:27     INFO -  Duplicates 9760 bytes:
05:27:27     INFO -    browser/chrome/browser/content/browser/defaultthemes/5.footer.png
05:27:27     INFO -    browser/chrome/browser/content/browser/defaultthemes/5.header.png

Comment 1

[Dão Gottwald [:dao]]

It's intentional that different components have their own icon copies when the contexts these icons are used in are different enough, so that these UIs can evolve separately without having to unwind cross-component dependencies all the time. I think this is the case for most items you listed, although probably not all of them.

Comment 2

[Tim Nguyen :ntim]

Most of these have been fixed in other bugs. The only remaining one is bookmarkProperties which is needed for XUL persistence: https://searchfox.org/mozilla-central/rev/c2bc259414706ef4be5d13df1344eebb7507a51b/browser/installer/allowed-dupes.mn#15-17