add android symbols upload to taskgraph

RESOLVED FIXED

Status

Firefox Build System
Task Configuration
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: kmoir, Assigned: kmoir)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
coop> jlund: does that mean the symbols task already exists, or is it yet to be implemented?
3:21 PM 
<jlund|mtg> coop: upload_symbols task is currently not scheduled for nightly graph case in taskgraph. dustin may correct me but I believe we could get it for free by simply adding something like "android-api-15-nightly/opt" to this list: https://dxr.mozilla.org/mozilla-central/source/taskcluster/ci/upload-symbols/kind.yml#16
3:57 PM 
<dustin> jlund|mtg: yup, assuming that task is smart enough to handle android symbols
4:03 PM 
<Callek> I wonder offhand if we'd need to extend the upload symbols stuff to be sure its not scheduled in !==nightly though, otherwise we'd end up scheduling the Nightly per-push due to optimize deeming it as "needed"
<coop> jlund|mtg: ok. it's something that we've called out specifically in the work tasks, so i want to make sure it gets done
<coop> kmoir: can i ask you to try adding those symbol tasks into the graph to at least see what breaks?
<kmoir> okay, I will add it to my to-do list
4:34 PM 
<coop> thanks
(Assignee)

Updated

2 years ago
Assignee: nobody → kmoir
Summary: add symbols upload to taskgraph → add android symbols upload to taskgraph
(Assignee)

Updated

2 years ago
Attachment #8805591 - Flags: review?(bugspam.Callek)
Comment on attachment 8805591 [details] [diff] [review]
bug1313190.patch

Review of attachment 8805591 [details] [diff] [review]:
-----------------------------------------------------------------

This does schedule it in the full taskgraph, however its not actually found in the `target` for android's nightly when we're using this, which it will need to be.
Attachment #8805591 - Flags: review?(bugspam.Callek) → review-
(Assignee)

Comment 4

2 years ago
Created attachment 8805655 [details] [diff] [review]
bug1313190-2.patch
Attachment #8805591 - Attachment is obsolete: true
(Assignee)

Comment 5

2 years ago
Created attachment 8805660 [details] [diff] [review]
bug1313190-3.patch
Attachment #8805655 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Attachment #8805660 - Flags: review?(bugspam.Callek)
Comment on attachment 8805660 [details] [diff] [review]
bug1313190-3.patch

Review of attachment 8805660 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/taskgraph/transforms/upload_symbols.py
@@ +28,5 @@
>          attributes = task.setdefault('attributes', {})
>          attributes['build_platform'] = build_platform
>          attributes['build_type'] = build_type
> +        if 'nightly' in build_platform:
> +            attributes['nightly'] = True

I'm less of a fan of doing a string search on `nightly` here, and would rather us do something like (psuedocode):

if 'nightly' in task['dependancy']['attributes']:
   ...

but this works with minimal fuss, so r+
Attachment #8805660 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 8

2 years ago
worked with nightly run
https://tools.taskcluster.net/push-inspector/#/AOYCArGwQvqagwrB3V0f_Q/D-RvInACS2GMqcSsfdiOuA?_k=7mhhy8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Updated

5 months ago
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.