131320 - [HAVE REVIEW] Make infobot friendlier

Status: VERIFIED FIXED

(Webtools Graveyard :: Mozbot, defect, P4)

Description

[Hixie (not reading bugmail)]

The Infobot module should have configurable prefixes to add to the front of
responses. e.g.:

   "I have heard that foo is bar."
   "Maybe foo is bar."
   "I seem to recall foo is bar."

Comment 1

[Hixie (not reading bugmail)]

Attachment: Patch: Version 1

This patch also contains a fix for bug 132264.

Adds various different prefixes to Infobot responses. Makes mozbot ignore
prefixes like "peterv:" at the start of auto-learnt factoids.

Comment 2

[Hixie (not reading bugmail)]

<timeless> word sicking
<word> i think sicking is Jonas Sicking (mailto:[e-mail]), one of the
brave men that has dared to wander the code of TransforMiiX, the mozilla XSLT engine
<Hixie> _oh_
<Hixie> NOW i remember why i didn't add prefixes to the infobot module originally!
<Hixie> oopsbot just autolearnt that "i think sicking" is "Jonas Sicking
(mailto:[e-mail]), ..."
<oopsbot> Hixie: ok
<Hixie> hmm
<Hixie> word just autolearnt that "i think sicking" is "Jonas Sicking
(mailto:[e-mail]), ..."
<word> OK, Hixie.
<Hixie> just autolearnt that "i think sicking"?
<oopsbot> Hixie: just autolearnt that "i think sicking" is "Jonas Sicking
(mailto:[e-mail]), ..."
<Hixie> word just autolearnt that "i think sicking"?
<oopsbot> Hixie: I have heard that word just autolearnt that "i think sicking"
is "Jonas Sicking (mailto:[e-mail]), ..."
<word> just autolearnt that "i think sicking" is "Jonas Sicking
(mailto:[e-mail]), ..."
<Hixie> causing a bot to learn ``I have heard that word just autolearnt that "i
think sicking"''...

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Patch looks good, but let the prefixes work when the bot responds to

   <caillon> botbot: caillon?

...as well.  Also, if you could add a "well, duh! " to the prefixes that would
be cool too ;)

Comment 4

[Hixie (not reading bugmail)]

ok, I made the changes

Comment 5

[Hixie (not reading bugmail)]

Checked in.

Comment 6

[Tanner M. Young [:tmyoung]]

Verified Fixed.