[EME] Resolve MediaKeySession.closed before the promise returned by MediaKeySession.close()

RESOLVED FIXED in Firefox 52

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

a year ago
The EME spec requires us to resolve the promise returned by MediaKeySession.close() after the MediaKeySession.close promise attribute. We're currently doing the opposite for both ClearKey and Widevine.

This causes us to fail these WPT:
http://www.w3c-test.org/encrypted-media/drm-mp4-playback-temporary-events.html
http://www.w3c-test.org/encrypted-media/clearkey-mp4-playback-temporary-events.html

WPT issue which updated the WPT to this behaviour:
https://github.com/w3c/web-platform-tests/issues/4058
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8804930 [details]
Bug 1313202 - Make ClearKey resolve MediaKeySession.closed promise before promise returned by MediaKeySession.close().

https://reviewboard.mozilla.org/r/88748/#review87830
Attachment #8804930 - Flags: review?(gsquelart) → review+

Comment 4

a year ago
mozreview-review
Comment on attachment 8804931 [details]
Bug 1313202 - Update MediaKeySession.close() to match EME spec.

https://reviewboard.mozilla.org/r/88750/#review87832
Attachment #8804931 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 5

a year ago
I'm reliably informed that Chrome is converting the Widevine CDM's InvalidAccessErrors to TypeErrors:

https://cs.chromium.org/chromium/src/media/blink/cdm_result_promise_helper.cc?sq=package:chromium&dr=CSs&rcl=1477509663&l=42

So we should do the same in the WidevineDecryptor to get the drm variant of this test to pass.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

a year ago
mozreview-review
Comment on attachment 8804950 [details]
Bug 1313202 - Convert InvalidAccessErrors coming out of the Widevine CDM to TypeErrors like Chrome does.

https://reviewboard.mozilla.org/r/88760/#review87856
Attachment #8804950 - Flags: review?(gsquelart) → review+

Comment 10

a year ago
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f6ae961e354
Make ClearKey resolve MediaKeySession.closed promise before promise returned by MediaKeySession.close(). r=gerald
https://hg.mozilla.org/integration/autoland/rev/2017b66912e8
Update MediaKeySession.close() to match EME spec. r=gerald
https://hg.mozilla.org/integration/autoland/rev/b3275f223e26
Convert InvalidAccessErrors coming out of the Widevine CDM to TypeErrors like Chrome does. r=gerald

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6f6ae961e354
https://hg.mozilla.org/mozilla-central/rev/2017b66912e8
https://hg.mozilla.org/mozilla-central/rev/b3275f223e26
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.