1313296 - Do not extract page metadata for "about" pages

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[:Grisha Kruglov]

We should either not extract page metadata for about: pages (preferred), or if we can't do that for some reason, we certainly shouldn't attempt to store it.

Comment 1

[Tom Klein]

Attachment: Bug 1313296 - Don't collect metadata for "about:" pages.

Review commit: https://reviewboard.mozilla.org/r/98262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98262/

Comment 2

[:Grisha Kruglov]

Comment on attachment 8818150 [details]
Bug 1313296 - Don't collect metadata for "about:" pages.

https://reviewboard.mozilla.org/r/98262/#review98680

Looks good. Thank you, Tom!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dbdd7f47e77
Don't collect metadata for "about:" pages. r=Grisha

Comment 4

[Richard Newman [:rnewman]]

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/AboutPages.java#31

exists for this kind of check. Please refactor when you get a chance.

Comment 5

[:Grisha Kruglov]

We're doing parsing in browser.js, and we want to skip it entirely when it's not necessary. AboutPages.java would be helpful if we wanted to skip the processing of the received metadata on the Java side, but I think we should aim to never even get to that point when we don't care about metadata.

There doesn't seem to be a canonical way/helper/util way of checking for about pages in javascript land (https://dxr.mozilla.org/mozilla-central/search?q=about%3A+path%3A*jsm&redirect=true), as far as I can tell.

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9dbdd7f47e77