Do not extract page metadata for "about" pages

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
General
P2
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Grisha, Assigned: Tom Klein)

Tracking

unspecified
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [MobileAS])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

We should either not extract page metadata for about: pages (preferred), or if we can't do that for some reason, we certainly shouldn't attempt to store it.
Comment hidden (mozreview-request)
(Reporter)

Comment 2

a year ago
mozreview-review
Comment on attachment 8818150 [details]
Bug 1313296 - Don't collect metadata for "about:" pages.

https://reviewboard.mozilla.org/r/98262/#review98680

Looks good. Thank you, Tom!
Attachment #8818150 - Flags: review?(gkruglov) → review+

Comment 3

a year ago
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9dbdd7f47e77
Don't collect metadata for "about:" pages. r=Grisha
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/AboutPages.java#31

exists for this kind of check. Please refactor when you get a chance.
Flags: needinfo?(gkruglov)
Assignee: nobody → twointofive
Status: NEW → ASSIGNED
We're doing parsing in browser.js, and we want to skip it entirely when it's not necessary. AboutPages.java would be helpful if we wanted to skip the processing of the received metadata on the Java side, but I think we should aim to never even get to that point when we don't care about metadata.

There doesn't seem to be a canonical way/helper/util way of checking for about pages in javascript land (https://dxr.mozilla.org/mozilla-central/search?q=about%3A+path%3A*jsm&redirect=true), as far as I can tell.
Flags: needinfo?(gkruglov)

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9dbdd7f47e77
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.