131330 - <wizard/> : Need a way to set background images in header box per wizardpage

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[racham]

Today, when we set a image as a background for wizard-header-box-1, it spans 
overall wizard pages as it is a property of wizard itself. I am wondering if 
there is a way to take option of setting a background image per wizard as we 
wish. One can set simply set the label where background image is not needed. 
This will be useful for ISPs as they try to brand each of wizard pages. 
Activation will need this as we try to customize each page. If there is already 
a way to do this, please add the description in here and close this as 
invalid. thanks.

Comment 1

[racham]

Marked nsbeta1 as we need this one for activation. 

Comment 2

[Peter Trudelle]

nsbeta1+/adt1 per Nav triage team.

Comment 3

[Joe Hewitt (gone)]

-> racham, I showed him how to fix this and he is working on it for activation

Comment 4

[racham]

Attachment: patch

This patch allows us to distingusih the pages by pageid and thus facilitating
style rules to be applied appropriately.

Comment 5

[racham]

Seth & Hewitt,

Reviews please ? Thanks.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 79050 [details] [diff] [review]
patch

sr=sspitzer

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 79050 [details] [diff] [review]
patch

sr=sspitzer

please add a comment to the code, indicating why setting this attribute is
useful.

Comment 8

[racham]

sure. thanks.

Comment 9

[racham]

Added comments :

          // Setting this attribute allows wizard's clients to dynamically
          // change the styles of each page based on purpose of the page. 


Blake,

Can you review the patch ? thanks.

bhuvan

Comment 10

[andreww]

Comment on attachment 79050 [details] [diff] [review]
patch

I was about to just review this but I find that it seems like looking at the
wizard js code as a whole that something seems missing.   Where in the wizard
can you "get" this currentpageid ? is it purely just so you have a hook into
css for selection?  Should there be a <property> tag as well?

Comment 11

[andreww]

Comment on attachment 79050 [details] [diff] [review]
patch

r=andreww after talking to bhuvan

Comment 12

[racham]

landed on the trunk.

Comment 13

[scottputterman]

Grace or Ninoschka, please test this on the trunk and update the bug with the
results.  Talk to Bhuvan about what needs to be tested.

Comment 14

[Grace Bush]

Netscape banner is showing (in both Modern and Classic theme) during Activation, 
both Registration and Downstream (at least on attempts to create new Webmail 
Account and new IM name)
looks great

Comment 15

[racham]

Comment on attachment 79050 [details] [diff] [review]
patch

r=andreww (from comment #11)

Comment 16

[scottputterman]

adding adt1.0.0+.  Please check this into the branch as soon as possible and add
the fixed1.0.0 keyword.

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 79050 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 18

[racham]

Fixed.

Comment 19

[shrirang khanzode]

v(stamp)

Comment 20

[scottputterman]

Bhuvan, was this checked into the branch also?  If so, please add the fixed1.0.0
keyword.

Comment 21

[racham]

Fixed both on branch and trunk. Sorry, missed adding keyword. Added fixed1.0.0 now.