Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
Storage
P3
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
SQLITE_OMIT_DECLTYPE allows prepared statements to save some memory, and our only use of it is in GetColumnDecltype API that is only used by tests to check it works :(

We should check addons usage of it, and if possible remove it.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

7 months ago
sorry for the reviews-spam, it's all tiny things.
(Assignee)

Updated

7 months ago
Assignee: nobody → mak77

Comment 3

7 months ago
mozreview-review
Comment on attachment 8807283 [details]
Bug 1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE.

https://reviewboard.mozilla.org/r/90498/#review90224

I double-checked the addons DXR and concur there does not seem to be any meaningfull fallout.  Thanks for the efforts to reduce library bloat!

I got three hits:
* a separate idl interface that does not overlap mozStorage's
* a query helper (possibly debug, hard to tell because of the minified JS) in an addon last updated 5 years ago with 3 users
* a comment in a storage-using library that seemed to be a note reminding of the available (or skipped?) functions.
Attachment #8807283 - Flags: review?(bugmail) → review+

Comment 4

7 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/059f143b7894
Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE. r=asuth

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/059f143b7894
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.