|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
SQLITE_OMIT_DECLTYPE allows prepared statements to save some memory, and our only use of it is in GetColumnDecltype API that is only used by tests to check it works :( We should check addons usage of it, and if possible remove it.
sorry for the reviews-spam, it's all tiny things.
Comment on attachment 8807283 [details] Bug 1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE. https://reviewboard.mozilla.org/r/90498/#review90224 I double-checked the addons DXR and concur there does not seem to be any meaningfull fallout. Thanks for the efforts to reduce library bloat! I got three hits: * a separate idl interface that does not overlap mozStorage's * a query helper (possibly debug, hard to tell because of the minified JS) in an addon last updated 5 years ago with 3 users * a comment in a storage-using library that seemed to be a note reminding of the available (or skipped?) functions.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/059f143b7894 Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE. r=asuth