Closed Bug 1313310 Opened 3 years ago Closed 3 years ago
we don't use deprecated function, and through this we could save some library footprint
Comment on attachment 8807258 [details] Bug 1313310 - Use SQLITE_OMIT_DEPRECATED. https://reviewboard.mozilla.org/r/90488/#review90222
Attachment #8807258 - Flags: review?(bugmail) → review+
ah, looks like sqlite3_trace is deprecated and we should instead use sqlite3_trace_v2...
I'm sorry Andrew, the previous patch was incomplete due to sqlite3_trace, I reimplemented it with sqlite3_trace_v2, and added timings too. Could you please have a second look at this? No hurry.
I guess we were both thrown by https://sqlite.org/compile.html#omit_deprecated seeming like it was comprehensive when it was only extremely helpful! ;) Looks good, thanks!
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4c050d33b842 Use SQLITE_OMIT_DEPRECATED. r=asuth
You need to log in before you can comment on or make changes to this bug.