The default bug view has changed. See this FAQ.

Use SQLITE_OMIT_DEPRECATED

RESOLVED FIXED in Firefox 52

Status

()

Toolkit
Storage
P3
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
we don't use deprecated function, and through this we could save some library footprint
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Assignee: nobody → mak77

Comment 2

5 months ago
mozreview-review
Comment on attachment 8807258 [details]
Bug 1313310 - Use SQLITE_OMIT_DEPRECATED.

https://reviewboard.mozilla.org/r/90488/#review90222
Attachment #8807258 - Flags: review?(bugmail) → review+
(Assignee)

Comment 3

5 months ago
ah, looks like sqlite3_trace is deprecated and we should instead use sqlite3_trace_v2...
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

5 months ago
I'm sorry Andrew, the previous patch was incomplete due to sqlite3_trace, I reimplemented it with sqlite3_trace_v2, and added timings too.
Could you please have a second look at this?
No hurry.
Flags: needinfo?(bugmail)
I guess we were both thrown by https://sqlite.org/compile.html#omit_deprecated seeming like it was comprehensive when it was only extremely helpful! ;)

Looks good, thanks!
Flags: needinfo?(bugmail)
Comment hidden (mozreview-request)

Comment 9

5 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/4c050d33b842
Use SQLITE_OMIT_DEPRECATED. r=asuth

Comment 10

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4c050d33b842
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.