Closed Bug 1313310 Opened 3 years ago Closed 3 years ago

Use SQLITE_OMIT_DEPRECATED

Categories

(Toolkit :: Storage, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: mak, Assigned: mak)

Details

Attachments

(1 file)

we don't use deprecated function, and through this we could save some library footprint
Assignee: nobody → mak77
Comment on attachment 8807258 [details]
Bug 1313310 - Use SQLITE_OMIT_DEPRECATED.

https://reviewboard.mozilla.org/r/90488/#review90222
Attachment #8807258 - Flags: review?(bugmail) → review+
ah, looks like sqlite3_trace is deprecated and we should instead use sqlite3_trace_v2...
I'm sorry Andrew, the previous patch was incomplete due to sqlite3_trace, I reimplemented it with sqlite3_trace_v2, and added timings too.
Could you please have a second look at this?
No hurry.
Flags: needinfo?(bugmail)
I guess we were both thrown by https://sqlite.org/compile.html#omit_deprecated seeming like it was comprehensive when it was only extremely helpful! ;)

Looks good, thanks!
Flags: needinfo?(bugmail)
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/4c050d33b842
Use SQLITE_OMIT_DEPRECATED. r=asuth
https://hg.mozilla.org/mozilla-central/rev/4c050d33b842
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.