Closed
Bug 1313315
Opened 8 years ago
Closed 8 years ago
Do construct CreateDecoderParams only on Windows build in VideoDecoderParent::RecvInit
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: JamesCheng, Assigned: JamesCheng)
Details
Attachments
(1 file)
Bug 1313315 - Do construct CreateDecoderParams only on Windows build in VideoDecoderParent::RecvInit
58 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
|
Details |
I found [1] only used when #ifdef XP_WIN took effect. I think we can move those it into #ifdef [1] http://searchfox.org/mozilla-central/rev/8cf1367dd89cc36ef8f025dfc6af6d5c086838a7/dom/media/ipc/VideoDecoderParent.cpp#79-83
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8805052 -
Flags: review?(matt.woodrow)
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8805052 [details] Bug 1313315 - Do construct CreateDecoderParams only on Windows build in VideoDecoderParent::RecvInit https://reviewboard.mozilla.org/r/88892/#review88170
Attachment #8805052 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bb8f38a1583f Do construct CreateDecoderParams only on Windows build in VideoDecoderParent::RecvInit r=mattwoodrow
Keywords: checkin-needed
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bb8f38a1583f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•