1313350 - Fix Storage panel integration with Variables view

Status: NEW

(DevTools :: Storage Inspector, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1309605.


STR:
1) Execute this on a page sessionStorage.setItem('a', '[[1],2]');
2) Open Dev Toolbox and select the Storage panel
3) Clicking the value produces an empty top level in variablesview.

See also:
https://bugzilla.mozilla.org/show_bug.cgi?id=1309605#c8

Honza

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Screen Shot 2016-10-29 at 22.06.48.png

This works fine for me... see screenshot.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #1)
> Created attachment 8805813 [details]
> Screen Shot 2016-10-29 at 22.06.48.png
> 
> This works fine for me... see screenshot.
See the 'Parsed Value' section in the side bar. The root item doesn't have a label. I believe that the root item shouldn't be there at all - the root should be 'a' in this case.


Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Mike, see also the patch attached to the bug 1309605. This comment is important:
https://bugzilla.mozilla.org/show_bug.cgi?id=1309605#c8

Honza

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on HOTFROG.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I could have sworn I have fixed this before but I can still reproduce it in Firefix 59.