Stop creating a new PrintTargetCG for each print page

RESOLVED FIXED

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwatt, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox52 affected)

Details

(Whiteboard: tpi:+)

(Reporter)

Description

2 years ago
Right now the XP_MACOSX hack in nsDeviceContext::BeginPage causes us to create a new PrintTargetCG for each print page. This breaks the usual semantics and usage of PrintTarget and makes the printing code harder to reason about. It also makes it harder to create instances of PrintTarget other than PrintTargetCG where we really want all the pages to end up together, such as if we want to use PrintTargetPDF. Se should really stop creating new PrintTarget instances and instead have PrintTargetCG manage the PMSessionGetCGGraphicsContext calls to get a new CGContextRef for each page as appropriate.

Updated

2 years ago
Priority: -- → P3
Whiteboard: tpi:+
(Reporter)

Comment 1

2 years ago
I fixed this in bug 1309272's "part 5" patch.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.