Closed Bug 1313370 Opened 9 years ago Closed 8 years ago

Reps should have a package.json

Categories

(DevTools :: Shared Components, defect)

Product:
DevTools
Component:
Shared Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: jlast, Unassigned)

Details

Honza and I discussed the benefits of having a Reps package.json in our 1.1. The Debugger currently copies the Reps files into the Debugger's devtools-modules package. https://github.com/devtools-html/debugger.html/tree/master/packages/devtools-modules/client/shared/components/reps This has the advantage of being fairly easy to do and to update, but it also has several disadvantages. It can be easy to miss a new file introduced that we're not tracking. It is possible to change a Rep file in the debugger package, which should be discouraged. It would be better if the debugger could simply install the devtools-reps module from NPM. This way, changes are made in m-c and can be versioned. If this goes well, having small npm packages for shared modules can be a pattern we apply to other modules.
Component: Developer Tools: Framework → Developer Tools: Shared Components
closing this as we'll do development in github
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.