1313392 - Consider decompiling bytecode to generate read-only errors.

Status: RESOLVED INCOMPLETE

(Core :: JavaScript Engine, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Spawned from bug 1304638, Nicolas suggested using the same mechanism to generate the normal error message.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1304638#c31

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Whoops, filled the bug from the wrong template.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Patch

This was the patch from bug 1304638.

Comment 3

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8805159 [details] [diff] [review]
Patch

Review of attachment 8805159 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.cpp
@@ +153,5 @@
> +static bool
> +LastFrameIsFunctionCall(JSContext* cx)
> +{
> +    FrameIter iter(cx);
> +    jsbytecode* pc = iter.pc();

"iter.pc()" is valid iff there is a frame.  These function call can be probably be made while using the jsapi, and this might trouble embedders to have either an assertion, or a crash on the next line.  Guard this with  "!iter.done()" condition.

@@ +154,5 @@
> +LastFrameIsFunctionCall(JSContext* cx)
> +{
> +    FrameIter iter(cx);
> +    jsbytecode* pc = iter.pc();
> +    return (JSOp)*pc == JSOP_FUNCALL;

This sounds incomplete, any reason why this only includes "fun.call(…)" and not "fun(…)" ?
Can you use "IsCallPC" function here?