Closed Bug 1313394 Opened 4 years ago Closed 4 years ago

Update build system to support 64-bit ASan DLLs

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

Currently we have clang_rt.asan_dynamic-i386.dll hard-coded in a couple of places.
Attached patch patchSplinter Review
Assignee: nobody → dmajor
Attachment #8805168 - Flags: review?(ted)
Comment on attachment 8805168 [details] [diff] [review]
patch

Review of attachment 8805168 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/sanitize.m4
@@ +14,5 @@
>  if test -n "$MOZ_ASAN"; then
>      MOZ_LLVM_HACKS=1
>      if test -n "$CLANG_CL"; then
> +        # Look for the ASan runtime binary
> +        if test -n "$HAVE_64BIT_BUILD"; then

Slight preference for `test "$CPU_ARCH" = "x86_64"` here.
Attachment #8805168 - Flags: review?(ted) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6587fbc2dbe
Update build system to support 64-bit ASan DLLs. r=ted
https://hg.mozilla.org/mozilla-central/rev/c6587fbc2dbe
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.