Closed
Bug 1313394
Opened 8 years ago
Closed 8 years ago
Update build system to support 64-bit ASan DLLs
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox52 fixed)
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
2.00 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Currently we have clang_rt.asan_dynamic-i386.dll hard-coded in a couple of places.
Assignee: nobody → dmajor
Attachment #8805168 -
Flags: review?(ted)
Comment 2•8 years ago
|
||
Comment on attachment 8805168 [details] [diff] [review] patch Review of attachment 8805168 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/autoconf/sanitize.m4 @@ +14,5 @@ > if test -n "$MOZ_ASAN"; then > MOZ_LLVM_HACKS=1 > if test -n "$CLANG_CL"; then > + # Look for the ASan runtime binary > + if test -n "$HAVE_64BIT_BUILD"; then Slight preference for `test "$CPU_ARCH" = "x86_64"` here.
Attachment #8805168 -
Flags: review?(ted) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c6587fbc2dbe Update build system to support 64-bit ASan DLLs. r=ted
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c6587fbc2dbe
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•