1313405 - MP4Demuxer::NotifyDataRemoved looks bogus

Status: RESOLVED INVALID

(Core :: Audio/Video, defect)

Description

[Nathan Froyd [:froydnj]]

We have:

https://dxr.mozilla.org/mozilla-central/rev/3f4c3a3cabaf94958834d3a8935adfb4a887942d/dom/media/fmp4/MP4Demuxer.cpp#200

void
MP4Demuxer::NotifyDataRemoved()
{
  for (uint32_t i = 0; i < mDemuxers.Length(); i++) {
    mDemuxers[i]->NotifyDataArrived();
  }
}

Shouldn't that NotifyDataArrived call be NotifyDataRemoved?

Comment 1

[Jean-Yves Avenard [:jya]]

No...

There's no MP4TrackDemuxer::NotifyDataRemoved to start with, and all we care about is to set a flag indicating to re calculate the buffered ranges.

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Jean-Yves Avenard [:jya] from comment #1)
> There's no MP4TrackDemuxer::NotifyDataRemoved to start with, and all we care
> about is to set a flag indicating to re calculate the buffered ranges.

That is...non-obvious. :(

Comment 3

[Jean-Yves Avenard [:jya]]

Feel free to remove MP4TrackDemuxer::NotifyDataArrived with something like NotifyDataArrivedOrGotRemoved
or whatever name is more obvious to you :)

NotifyDataRemoved is only use with MSE for what it's worth.