MP4Demuxer::NotifyDataRemoved looks bogus

RESOLVED INVALID

Status

()

RESOLVED INVALID
2 years ago
2 years ago

People

(Reporter: froydnj, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox52 affected)

Details

(Reporter)

Description

2 years ago
We have:

https://dxr.mozilla.org/mozilla-central/rev/3f4c3a3cabaf94958834d3a8935adfb4a887942d/dom/media/fmp4/MP4Demuxer.cpp#200

void
MP4Demuxer::NotifyDataRemoved()
{
  for (uint32_t i = 0; i < mDemuxers.Length(); i++) {
    mDemuxers[i]->NotifyDataArrived();
  }
}

Shouldn't that NotifyDataArrived call be NotifyDataRemoved?
No...

There's no MP4TrackDemuxer::NotifyDataRemoved to start with, and all we care about is to set a flag indicating to re calculate the buffered ranges.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
(Reporter)

Comment 2

2 years ago
(In reply to Jean-Yves Avenard [:jya] from comment #1)
> There's no MP4TrackDemuxer::NotifyDataRemoved to start with, and all we care
> about is to set a flag indicating to re calculate the buffered ranges.

That is...non-obvious. :(
Feel free to remove MP4TrackDemuxer::NotifyDataArrived with something like NotifyDataArrivedOrGotRemoved
or whatever name is more obvious to you :)

NotifyDataRemoved is only use with MSE for what it's worth.
You need to log in before you can comment on or make changes to this bug.