1313428 - Autophone - ap-assignments.py - autophone_path thinko

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

ap-assignments does not take into account the [builds] buildtypes in test config files which results in all tests being treated as if they have both opt and debug set. This is due to a thinko when I added the utils.autophone_path() function:

--- a/ap-assignments.py
+++ b/ap-assignments.py
@@ -219,7 +219,7 @@ for test_name in test_sections:
         if test_option == 'config':
             # config is required and is the first option in the section.
             test_config = ConfigParser.RawConfigParser()
-            test_config.read("%s/tests/%s" % (autophone_path,
+            test_config.read("%s/tests/%s" % (autophone_path(),
                                               test_value))
             try:
                 test_build_types = test_config.get('builds', 'buildtypes').split()

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1313428-v1.patch

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: bug-1313428-2-v1.patch

updates ap-assignments.py to add distinct opt,debug timing, update run times and load based on recent history and https://treeherder.mozilla.org/#/jobs?repo=try&revision=0af35e37244027de0a91b4514c20654d561e4144&group_state=expanded and removes the fx-team repo since it is being obsoleted in bug 1296046.

Comment 3

[Geoff Brown [:gbrown]]

Comment on attachment 8805600 [details] [diff] [review]
bug-1313428-2-v1.patch

Why no more fx-team?

Comment 4

[Geoff Brown [:gbrown]]

Oh, I see - bug 1296046.

Comment 5

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/ebe2dcd8f29297408dcd5ae725498ffadfa2128c
https://github.com/mozilla/autophone/commit/775da797f7c477ce6dc2d0e8ab0b9979cd029393

Comment 6

[Bob Clary [:bc] (inactive)]

deployed ~2016-11-13 22:20 PST.