Closed
Bug 1313431
Opened 9 years ago
Closed 7 years ago
Update commit data on rebase
Categories
(Conduit Graveyard :: Transplant, defect)
Conduit Graveyard
Transplant
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1243708
People
(Reporter: gps, Unassigned)
Details
When we rebase commits during autoland, I think we should rewrite the commit date to <now>. This will yield accurate relative dates in the final Firefox commit history that will largely mirror the pushlog dates and will yield more accurate results when doing date-based queries.
The main downside of this is the original date from the commit author is lost. But I don't think that provides much value once it lands. This can be useful for tracking how long it takes to develop a commit - time between initial authorship and landing. But we can get that from data in the MozReview repo.
FWIW, rewriting the dates will improve `git log` output in the case where there are merge commits (which will be true for the next several months until we kill the inbound repo). By default, git orders commits by commit date, where "commit date" is distinct from "author date" since git tracks them separately. However, since Mercurial only tracks a single date natively, git will copy the Mercurial date to both fields when it does the VCS conversation, so Git "clones" of Mercurial repos effectively only have a single date today.
Comment 1•9 years ago
|
||
How about adding the same info hg-git (and git cinnabar, I preserved that in a compatible way) adds to map git committer data instead?
Comment 2•9 years ago
|
||
So, leave author unchanged, but add committer info with date set to <now> (and maybe committer name autoland)
Updated•7 years ago
|
Product: MozReview → Conduit
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Updated•1 year ago
|
Product: Conduit → Conduit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•