1313463 - Convert XPCOM CppUnitTests to gtests

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Eric Rahm [:erahm]]

We'd like to convert as many of our CPP unit tests to gtests as possible.

This generally just involves:
  #1 - Remove the test's |main| function
  #2 - Switch over to gtest assertions
  #3 - Move the file to xpcom/tests/gtest and add it to xpcom/tests/gtest/moz.build

The current list is:

> GeckoCppUnitTests([
>     'ShowAlignments',
>     'TestAutoPtr',
>     'TestAutoRef',
>     'TestCOMArray',
>     'TestCOMPtr',
>     'TestCOMPtrEq',
>     'TestFile',
>     'TestHashtables',
>     'TestID',
>     'TestNsRefPtr',
>     'TestObserverArray',
>     'TestObserverService',
>     'TestStringAPI',
>     'TestTArray',
>     'TestTextFormatter',
>     'TestThreadUtils',
>     'TestTimers'
> ])
>
> if CONFIG['MOZ_MEMORY']:
>     GeckoCppUnitTests([
>         'TestJemalloc',
>     ])
>
> if CONFIG['MOZ_DEBUG'] and CONFIG['OS_ARCH'] not in ('WINNT'):
>     # FIXME bug 523392: TestDeadlockDetector doesn't like Windows
>     # FIXME bug 523378: also fails on OS X
>     GeckoCppUnitTests([
>         'TestDeadlockDetector',
>         'TestDeadlockDetectorScalability',
>     ])

Comment 1

[Eric Rahm [:erahm]]

I've landed all the blockers, hopefully everything sticks and we should be good to go.

Comment 2

[Nicholas Nethercote [inactive]]

All blocking bugs are closed. Thank you, erahm.