Closed Bug 1313463 Opened 3 years ago Closed 3 years ago

Convert XPCOM CppUnitTests to gtests

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: erahm, Unassigned)

References

Details

We'd like to convert as many of our CPP unit tests to gtests as possible.

This generally just involves:
  #1 - Remove the test's |main| function
  #2 - Switch over to gtest assertions
  #3 - Move the file to xpcom/tests/gtest and add it to xpcom/tests/gtest/moz.build

The current list is:

> GeckoCppUnitTests([
>     'ShowAlignments',
>     'TestAutoPtr',
>     'TestAutoRef',
>     'TestCOMArray',
>     'TestCOMPtr',
>     'TestCOMPtrEq',
>     'TestFile',
>     'TestHashtables',
>     'TestID',
>     'TestNsRefPtr',
>     'TestObserverArray',
>     'TestObserverService',
>     'TestStringAPI',
>     'TestTArray',
>     'TestTextFormatter',
>     'TestThreadUtils',
>     'TestTimers'
> ])
>
> if CONFIG['MOZ_MEMORY']:
>     GeckoCppUnitTests([
>         'TestJemalloc',
>     ])
>
> if CONFIG['MOZ_DEBUG'] and CONFIG['OS_ARCH'] not in ('WINNT'):
>     # FIXME bug 523392: TestDeadlockDetector doesn't like Windows
>     # FIXME bug 523378: also fails on OS X
>     GeckoCppUnitTests([
>         'TestDeadlockDetector',
>         'TestDeadlockDetectorScalability',
>     ])
Depends on: 1313466
Depends on: 1313467
Depends on: 1313468
Depends on: 1313469
Depends on: 1313470
Depends on: 1313471
Depends on: 1313472
Depends on: 1313473
Depends on: 1313474
Depends on: 1313475
Depends on: 1313477
Depends on: 1313479
Depends on: 1313480
Depends on: 1313481
Depends on: 1313482
Depends on: 1313483
Depends on: 1313484
Depends on: 1313485
Depends on: 1313488
Depends on: 1313489
Depends on: 1315830
No longer depends on: 1313485
Depends on: 1316189
Depends on: 1316191
Depends on: 1316193
Depends on: 1316194
Depends on: 1316195
Depends on: 1313485
Depends on: 1316424
Depends on: 1316436
Depends on: 1316437
I've landed all the blockers, hopefully everything sticks and we should be good to go.
Depends on: 1316732
Depends on: 1316737
Depends on: 1316738
Depends on: 1316904
All blocking bugs are closed. Thank you, erahm.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.