1313467 - Convert XPCOM test TestAutoPtr to a gtest

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Eric Rahm [:erahm]]

Convert xpcom/tests/TestAutoPtr.cpp to a gtest and move to xpcom/tests/gtest/.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Part 1: Remove RefPtr tests from TestAutoPtr

This is a test for nsAutoPtr, we shouldn't be testing RefPtr here.

MozReview-Commit-ID: IqwgINAuYar

Comment 2

[Eric Rahm [:erahm]]

Attachment: Part 2: Move tests into individual functions

This just moves code into separate functions. No logic changes were made.

MozReview-Commit-ID: 98NqhCb4T67

Comment 3

[Eric Rahm [:erahm]]

Attachment: Part 3: Cleanup the formatting of the rest of the file

MozReview-Commit-ID: AfMDPcBjf3Y

Comment 4

[Eric Rahm [:erahm]]

Attachment: Part 4: Convert TestAutoPtr to a gtest

MozReview-Commit-ID: EOKHAQyZ4fZ

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8805369 [details] [diff] [review]
Part 4: Convert TestAutoPtr to a gtest

Review of attachment 8805369 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with changes below.

::: xpcom/tests/gtest/TestAutoPtr.cpp
@@ +7,5 @@
>  #include "nsAutoPtr.h"
> +#include "gtest/gtest.h"
> +//#include <stdio.h>
> +//#include "nscore.h"
> +//#include "mozilla/Attributes.h"

Might as well just delete these while you're at it, rather than commenting them out?

::: xpcom/tests/moz.build
@@ -45,5 @@
>  
>  XPCSHELL_TESTS_MANIFESTS += ['unit/xpcshell.ini']
>  
>  GeckoCppUnitTests([
> -    'TestAutoPtr',

You need to remove this from testing/cppunittest.ini as well.

Comment 6

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/107eb264a40d19ecdcb1af3d09959a547d397b9d
Bug 1313467 - Part 1: Remove RefPtr tests from TestAutoPtr. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fae1bbd3819833d07fd47f7b9b15b8e42e12452
Bug 1313467 - Part 2: Move tests into individual functions. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/0acc0a131101e59d9b6dbc1dded254ebf6707104
Bug 1313467 - Part 3: Cleanup the formatting of the rest of the file. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c25a6ed5914b926e5c554c5f38a2e71ee0673e7
Bug 1313467 - Part 4: Convert TestAutoPtr to a gtest. r=froydnj

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/561b87e98adacbd47769a71a0e6c72c5dcf66a9d to get at bug 1313470 for its crashes on OS X.

Comment 8

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7abe65a85676c0f538b6871fee5ecc3ee3a17cba
Bug 1313467 - Part 1: Remove RefPtr tests from TestAutoPtr. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d1eb2bddef98eaf9ab1069c32f16538a5c2a893
Bug 1313467 - Part 2: Move tests into individual functions. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7335cf91ad0ad8b9f798735490a15876aa05bb8
Bug 1313467 - Part 3: Cleanup the formatting of the rest of the file. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ca9d7aa4dc75e39aa260313d8ba552b2e76322a
Bug 1313467 - Part 4: Convert TestAutoPtr to a gtest. r=froydnj

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7abe65a85676
https://hg.mozilla.org/mozilla-central/rev/2d1eb2bddef9
https://hg.mozilla.org/mozilla-central/rev/d7335cf91ad0
https://hg.mozilla.org/mozilla-central/rev/6ca9d7aa4dc7