Closed Bug 1313468 Opened 3 years ago Closed 3 years ago

Convert XPCOM test TestAutoRef to a gtest

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

Convert xpcom/tests/TestAutoRef.cpp to a gtest and move to xpcom/tests/gtest/.
MozReview-Commit-ID: GkEPSkzNeuB
Attachment #8805630 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8805630 [details] [diff] [review]
Convert XPCOM test TestAutoRef to a gtest

Review of attachment 8805630 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/tests/gtest/TestStorageStream.cpp
@@ +11,5 @@
>  #include "nsICloneableInputStream.h"
>  #include "nsIInputStream.h"
>  #include "nsIOutputStream.h"
>  #include "nsIStorageStream.h"
> +#include "nsTArray.h"

I assume this is a unified build fix.
Attachment #8805630 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8805630 [details] [diff] [review]
> Convert XPCOM test TestAutoRef to a gtest
> 
> Review of attachment 8805630 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: xpcom/tests/gtest/TestStorageStream.cpp
> @@ +11,5 @@
> >  #include "nsICloneableInputStream.h"
> >  #include "nsIInputStream.h"
> >  #include "nsIOutputStream.h"
> >  #include "nsIStorageStream.h"
> > +#include "nsTArray.h"
> 
> I assume this is a unified build fix.

Yeah. I can probably split those out in the future if it helps.
https://hg.mozilla.org/mozilla-central/rev/825b955d94df
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.