Closed
Bug 1313468
Opened 9 years ago
Closed 9 years ago
Convert XPCOM test TestAutoRef to a gtest
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
|
4.34 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Convert xpcom/tests/TestAutoRef.cpp to a gtest and move to xpcom/tests/gtest/.
|
Assignee | |
Comment 1•9 years ago
|
||
MozReview-Commit-ID: GkEPSkzNeuB
Attachment #8805630 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8805630 [details] [diff] [review]
Convert XPCOM test TestAutoRef to a gtest
Review of attachment 8805630 [details] [diff] [review]:
-----------------------------------------------------------------
::: xpcom/tests/gtest/TestStorageStream.cpp
@@ +11,5 @@
> #include "nsICloneableInputStream.h"
> #include "nsIInputStream.h"
> #include "nsIOutputStream.h"
> #include "nsIStorageStream.h"
> +#include "nsTArray.h"
I assume this is a unified build fix.
Attachment #8805630 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8805630 [details] [diff] [review]
> Convert XPCOM test TestAutoRef to a gtest
>
> Review of attachment 8805630 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: xpcom/tests/gtest/TestStorageStream.cpp
> @@ +11,5 @@
> > #include "nsICloneableInputStream.h"
> > #include "nsIInputStream.h"
> > #include "nsIOutputStream.h"
> > #include "nsIStorageStream.h"
> > +#include "nsTArray.h"
>
> I assume this is a unified build fix.
Yeah. I can probably split those out in the future if it helps.
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/02959aa60196a5d1ea833f1d21052ec50b99058a
Bug 1313468: Convert XPCOM test TestAutoRef to a gtest. r=froydnj
|
||
Comment 5•9 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/561b87e98adacbd47769a71a0e6c72c5dcf66a9d to get at bug 1313470 for its crashes on OS X.
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/825b955d94df324138255e4ee8e5a4e241171a0d
Bug 1313468: Convert XPCOM test TestAutoRef to a gtest. r=froydnj
|
|
||
Comment 7•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•