Closed Bug 1313471 Opened 3 years ago Closed 3 years ago

Convert XPCOM test TestCOMPtrEq to a gtest

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(2 files, 1 obsolete file)

Convert xpcom/tests/TestCOMPtrEq.cpp to a gtest and move to xpcom/tests/gtest/.
Attached patch Part 0: Cleanup indentation (obsolete) — Splinter Review
MozReview-Commit-ID: CjOMjvGMaEC
Attachment #8806123 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
MozReview-Commit-ID: FzGVmd0LO73
Attachment #8806124 - Flags: review?(nfroyd)
MozReview-Commit-ID: GifbCK1zzxh
Attachment #8806125 - Flags: review?(nfroyd)
Comment on attachment 8806123 [details] [diff] [review]
Part 0: Cleanup indentation

This patch appears to be empty?
Attachment #8806123 - Flags: review?(nfroyd)
Attachment #8806124 - Flags: review?(nfroyd) → review+
Attachment #8806125 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #4)
> Comment on attachment 8806123 [details] [diff] [review]
> Part 0: Cleanup indentation
> 
> This patch appears to be empty?

Looks like it got folded into the cleanup in part 1, I'll remove the empty patch.
Attachment #8806123 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/0ce11eb36fe5
https://hg.mozilla.org/mozilla-central/rev/67374493c153
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.