Closed
Bug 1313472
Opened 8 years ago
Closed 8 years ago
Convert XPCOM test TestFile to a gtest
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(2 files)
|
27.24 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
|
19.59 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Convert xpcom/tests/TestFile.cpp to a gtest and move to xpcom/tests/gtest/.
|
Assignee | |
Comment 1•8 years ago
|
||
MozReview-Commit-ID: 8LrPZNELGkJ
Attachment #8806168 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•8 years ago
|
||
This is a very straightforward conversion of TestFile to a gtest. It sticks with using one main test function to avoid dealing with possible dependency issues between subtests. MozReview-Commit-ID: IoIeGgisMGE
Attachment #8806169 -
Flags: review?(nfroyd)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8806168 [details] [diff] [review] Part 0: Cleanup indentation Review of attachment 8806168 [details] [diff] [review]: ----------------------------------------------------------------- Please removing trailing whitespace as well. r=me with that.
Attachment #8806168 -
Flags: review?(nfroyd) → review+
|
|
||
Updated•8 years ago
|
Attachment #8806169 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
(In reply to Nathan Froyd [:froydnj] from comment #3) > Comment on attachment 8806168 [details] [diff] [review] > Part 0: Cleanup indentation > > Review of attachment 8806168 [details] [diff] [review]: > ----------------------------------------------------------------- > > Please removing trailing whitespace as well. r=me with that. Updated locally.
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d84926813e91fc3c6c3fc95d2aca5436cf89d05 Bug 1313472 - Part 0: Cleanup indentation. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/9a33c84ab30a6e67a605b73337feb9ab7744458f Bug 1313472 - Part 1: Convert XPCOM test TestFile to a gtest. r=froydnj
|
||
Comment 6•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/561b87e98adacbd47769a71a0e6c72c5dcf66a9d to get at bug 1313470 for its crashes on OS X.
|
|
Assignee | |
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0358531f775aef1892c0661dbd306fcfd138e74 Bug 1313472 - Part 0: Cleanup indentation. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/c663ca85238762bb99b399ae3b64048ac4a33fc6 Bug 1313472 - Part 1: Convert XPCOM test TestFile to a gtest. r=froydnj
|
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f0358531f775 https://hg.mozilla.org/mozilla-central/rev/c663ca852387
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•