Closed Bug 1313472 Opened 3 years ago Closed 3 years ago

Convert XPCOM test TestFile to a gtest

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(2 files)

Convert xpcom/tests/TestFile.cpp to a gtest and move to xpcom/tests/gtest/.
MozReview-Commit-ID: 8LrPZNELGkJ
Attachment #8806168 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
This is a very straightforward conversion of TestFile to a gtest. It sticks
with using one main test function to avoid dealing with possible dependency
issues between subtests.

MozReview-Commit-ID: IoIeGgisMGE
Attachment #8806169 - Flags: review?(nfroyd)
Comment on attachment 8806168 [details] [diff] [review]
Part 0: Cleanup indentation

Review of attachment 8806168 [details] [diff] [review]:
-----------------------------------------------------------------

Please removing trailing whitespace as well.  r=me with that.
Attachment #8806168 - Flags: review?(nfroyd) → review+
Attachment #8806169 - Flags: review?(nfroyd) → review+
(In reply to Nathan Froyd [:froydnj] from comment #3)
> Comment on attachment 8806168 [details] [diff] [review]
> Part 0: Cleanup indentation
> 
> Review of attachment 8806168 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please removing trailing whitespace as well.  r=me with that.

Updated locally.
https://hg.mozilla.org/mozilla-central/rev/f0358531f775
https://hg.mozilla.org/mozilla-central/rev/c663ca852387
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.