1313479 - Convert XPCOM test TestObserverService to a gtest

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Eric Rahm [:erahm]]

Convert xpcom/tests/TestObserverService.cpp to a gtest and move to xpcom/tests/gtest/.

Comment 1

[Eric Rahm [:erahm]]

Just a note: it looks like this test currently doesn't do anything because it doesn't have a ScopedXPCOM declaration.

Comment 2

[Eric Rahm [:erahm]]

Attachment: Part 0: Cleanup indentation

MozReview-Commit-ID: 7PAMbXHB5Ws

Comment 3

[Eric Rahm [:erahm]]

Attachment: Part 0-1: Add missing includes to unified gtests

MozReview-Commit-ID: 4KVwMQJcAIS

Comment 4

[Eric Rahm [:erahm]]

Attachment: Part 1: Convert TestObserverService to a gtest

This is a straightforward conversion to a gtest. The test itself is updated
to use RefPtr/nsCOMPtr where appropriate to avoid memory leaks.

MozReview-Commit-ID: JyHF3iTaoOg

Comment 5

[Eric Rahm [:erahm]]

Attachment: Part 2: Expand and split out TestObserverService tests

This splits out enumertion testing, adds testing of weak references, and other
basic tests for add and remove functions.

MozReview-Commit-ID: CLEafPJhe3z

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8806828 [details] [diff] [review]
Part 1: Convert TestObserverService to a gtest

Review of attachment 8806828 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/tests/gtest/TestObserverService.cpp
@@ -55,5 @@
> -  nsCString topic( aTopic );
> -  nsString data( someData );
> -  /*
> -     The annoying double-cast below is to work around an annoying bug in
> -     the compiler currently used on wensleydale.  This is a test.

o.O

Comment 7

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9559827d07d0f7ddfbf38eec42140c4b6f26195e
Bug 1313479 - Part 0: Cleanup indentation. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/fd302c72543de9f896f35fa87d9b2d07f49a4f1f
Bug 1313479 - Part 0-1: Add missing includes to unified gtests. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/921433b91312e220341c858581e852c843d89d21
Bug 1313479 - Part 1: Convert TestObserverService to a gtest. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3b30fb7d3e6a4f97889180b6348d7771bd05891
Bug 1313479 - Part 2: Expand and split out TestObserverService tests. r=froydnj

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9559827d07d0
https://hg.mozilla.org/mozilla-central/rev/fd302c72543d
https://hg.mozilla.org/mozilla-central/rev/921433b91312
https://hg.mozilla.org/mozilla-central/rev/a3b30fb7d3e6