Closed
Bug 1313480
Opened 9 years ago
Closed 9 years ago
Remove XPCOM test TestStringAPI
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
|
8.03 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Convert xpcom/tests/TestStringAPI.cpp to a gtest and move to xpcom/tests/gtest/.
|
Assignee | |
Comment 1•9 years ago
|
||
Once the xpcom glue library is removed we will no longer need an external
StringAPI, so this test can go away.
MozReview-Commit-ID: DdGV2dWvlK1
Attachment #8806841 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → erahm
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
This one's a bit of a catch-22. It would be nice to remove this in the same patch that kills the xpcom glue lib, but we can't kill the glue lib until all GeckoCppUnitTests are gone.
Summary: Convert XPCOM test TestStringAPI to a gtest → Remove XPCOM test TestStringAPI
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8806841 [details] [diff] [review]
Remove test TestStringAPI
Review of attachment 8806841 [details] [diff] [review]:
-----------------------------------------------------------------
\o/
Attachment #8806841 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/51d34a672785d377376a9f277fab1fd37fd3ac6a
Bug 1313480 - Remove test TestStringAPI. r=froydnj
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•