Convert XPCOM test TestDeadlockDetector to a gtest

RESOLVED FIXED in Firefox 52

Status

()

Core
XPCOM
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(2 attachments)

Convert xpcom/tests/TestDeadlockDetector.cpp to a gtest and move to xpcom/tests/gtest/.
This one's interesting, it's testing that we report deadlocks correctly and crash. To do that it spins up sub-processes that actually crash and just checks the stderr output for the correct message. We can't do that with gtest (there's no process to run since all the tests are in one executable).

But there is gtest death tests such as ASSERT_DEATH. These fork the process and make sure a process crashes and output matches a given regex which sounds about what we need. If that doesn't work there's also prior art in TestPLDHash [1] that forks and checks for a crash (so it's debug/linux only AFAICT).

[1] http://searchfox.org/mozilla-central/rev/f5c9e9a249637c9abd88754c8963ecb3838475cb/xpcom/tests/gtest/TestPLDHash.cpp#35
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbaf9f78c7a
Created attachment 8807363 [details] [diff] [review]
Part 0: Adding missing includes

Add missing includes to fix unified builds.

MozReview-Commit-ID: 3xkozGdrdBf
Attachment #8807363 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Created attachment 8807364 [details] [diff] [review]
Part 1: Convert XPCOM test TestDeadlockDetector to a gtest

This converts TestDeadlockDetector to a gtest. The logic for spawning off
subprocesses is replaced with gtest's built-in death tests. On linux this will
clone() the process and assert that the child process generates the appropriate
assertion message. On OSX it will use fork(). In theory this should work on
Windows as well buy spawning a new process but this test currently disabled
there.

MozReview-Commit-ID: 9Sl0hHBVGT3
Attachment #8807364 - Flags: review?(nfroyd)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e731b0069e6e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=003e2a442607
Blocks: 1315138
Attachment #8807363 - Flags: review?(nfroyd) → review+
Comment on attachment 8807364 [details] [diff] [review]
Part 1: Convert XPCOM test TestDeadlockDetector to a gtest

Review of attachment 8807364 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: in the commit message, "this test *is* currently disabled there."
Attachment #8807364 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/22e770047827a7852201162b86b661cee76479dc
Bug 1313488 - Part 0: Adding missing includes. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbd9b56b50e73bf584c5ae8b38e08faac490d7e7
Bug 1313488 - Part 1: Convert XPCOM test TestDeadlockDetector to a gtest. r=froydnj
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/01800003ec3b043995e4ec1daaaf827e7ee2bbee for OS X builds being silly and continuing to burn like https://treeherder.mozilla.org/logviewer.html#?job_id=38802396&repo=mozilla-inbound even after the one where they started doing it was backed out for something else.
https://hg.mozilla.org/integration/mozilla-inbound/rev/d769f46c4248935ab000186136cdb21640d3b503
Bug 1313488 - Part 0: Adding missing includes. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/deabf7bc65262d5470bd24590393f5fd2c0f34fe
Bug 1313488 - Part 1: Convert XPCOM test TestDeadlockDetector to a gtest. r=froydnj
Backed out for leak detected in Gtest on Linux x64 debug:

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d76c0ab3a375e9e89094ea993755dac8a932f81
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2311b5d668122ebaea4aa132bec5da88b23f9f1

Also had to backout bug 1313489 to get no failing hunks on backout:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3aa99c2ab46d92ca0f1480d36aed87b49c575efd
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e21f3a89751b5bf85d8c10b983dfcc845452cf8

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=deabf7bc65262d5470bd24590393f5fd2c0f34fe
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=38915293&repo=mozilla-inbound

[task 2016-11-09T19:33:57.785686Z] 19:33:57     INFO -  TEST-PASS | GTest unit test: passed
[task 2016-11-09T19:33:57.786661Z] 19:33:57     INFO -  Passed: 3223
[task 2016-11-09T19:33:57.786991Z] 19:33:57     INFO -  Failed: 0
[task 2016-11-09T19:33:57.799638Z] 19:33:57     INFO -  [1116] WARNING: An event was posted to a thread that will never run it (rejected): file /home/worker/workspace/build/src/xpcom/threads/nsThread.cpp, line 695
[task 2016-11-09T19:33:57.799993Z] 19:33:57     INFO -  [1116] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/security/manager/ssl/DataStorage.cpp, line 833
[task 2016-11-09T19:33:57.800419Z] 19:33:57     INFO -  [1116] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/security/manager/ssl/DataStorage.cpp, line 880
[task 2016-11-09T19:33:57.815176Z] 19:33:57     INFO -  [1116] WARNING: An event was posted to a thread that will never run it (rejected): file /home/worker/workspace/build/src/xpcom/threads/nsThread.cpp, line 695
[task 2016-11-09T19:33:57.815554Z] 19:33:57     INFO -  [1116] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/security/manager/ssl/DataStorage.cpp, line 833
[task 2016-11-09T19:33:57.816142Z] 19:33:57     INFO -  [1116] WARNING: 'NS_FAILED(rv)', file /home/worker/workspace/build/src/security/manager/ssl/DataStorage.cpp, line 880
[task 2016-11-09T19:33:57.816732Z] 19:33:57     INFO -  [1116] WARNING: NS_ENSURE_TRUE(maybeContext) failed: file /home/worker/workspace/build/src/xpcom/threads/nsThread.cpp, line 977
[task 2016-11-09T19:33:57.850927Z] 19:33:57     INFO -  [1116] WARNING: '!compMgr', file /home/worker/workspace/build/src/xpcom/glue/nsComponentManagerUtils.cpp, line 63
[task 2016-11-09T19:33:57.851182Z] 19:33:57     INFO -  Finished running GTest tests.
[task 2016-11-09T19:33:57.851544Z] 19:33:57     INFO -  [1116] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 172
[task 2016-11-09T19:33:57.852144Z] 19:33:57     INFO -  [1116] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 172
[task 2016-11-09T19:33:57.852666Z] 19:33:57     INFO -  [1116] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 172
[task 2016-11-09T19:33:57.857521Z] 19:33:57     INFO -  nsStringStats
[task 2016-11-09T19:33:57.857560Z] 19:33:57     INFO -   => mAllocCount:         327046
[task 2016-11-09T19:33:57.857588Z] 19:33:57     INFO -   => mReallocCount:        22137
[task 2016-11-09T19:33:57.857628Z] 19:33:57     INFO -   => mFreeCount:          326941  --  LEAKED 105 !!!
[task 2016-11-09T19:33:57.857661Z] 19:33:57     INFO -   => mShareCount:         451527
[task 2016-11-09T19:33:57.857692Z] 19:33:57     INFO -   => mAdoptCount:          10758
[task 2016-11-09T19:33:57.857715Z] 19:33:57     INFO -   => mAdoptFreeCount:      10759
[task 2016-11-09T19:33:57.857738Z] 19:33:57     INFO -   => Process ID: 1116, Thread ID: 140055506900800
[task 2016-11-09T19:33:57.885618Z] 19:33:57     INFO -  mozcrash INFO | Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /home/worker/workspace/build/tests/gtest/61731a8f-930c-0d8b-0ee3b637-75983984.dmp /home/worker/workspace/build/symbols
[task 2016-11-09T19:34:05.030965Z] 19:34:05     INFO -  mozcrash INFO | Saved minidump as /home/worker/workspace/build/blobber_upload_dir/61731a8f-930c-0d8b-0ee3b637-75983984.dmp
[task 2016-11-09T19:34:05.031278Z] 19:34:05     INFO -  mozcrash INFO | Saved app info as /home/worker/workspace/build/blobber_upload_dir/61731a8f-930c-0d8b-0ee3b637-75983984.extra
[task 2016-11-09T19:34:05.031437Z] 19:34:05  WARNING -  PROCESS-CRASH | gtest | application crashed [@ mozalloc_abort]
[task 2016-11-09T19:34:05.032183Z] 19:34:05     INFO -  Crash dump filename: /home/worker/workspace/build/tests/gtest/61731a8f-930c-0d8b-0ee3b637-75983984.dmp
[task 2016-11-09T19:34:05.032655Z] 19:34:05     INFO -  Operating system: Linux
[task 2016-11-09T19:34:05.032944Z] 19:34:05     INFO -                    0.0.0 Linux 3.13.0-100-generic #147-Ubuntu SMP Tue Oct 18 16:48:51 UTC 2016 x86_64
[task 2016-11-09T19:34:05.033248Z] 19:34:05     INFO -  CPU: amd64
[task 2016-11-09T19:34:05.033554Z] 19:34:05     INFO -       family 6 model 62 stepping 4
[task 2016-11-09T19:34:05.033854Z] 19:34:05     INFO -       4 CPUs
[task 2016-11-09T19:34:05.034158Z] 19:34:05     INFO -  GPU: UNKNOWN
[task 2016-11-09T19:34:05.034459Z] 19:34:05     INFO -  Crash reason:  SIGSEGV
[task 2016-11-09T19:34:05.034754Z] 19:34:05     INFO -  Crash address: 0x0
[task 2016-11-09T19:34:05.035058Z] 19:34:05     INFO -  Process uptime: not available
[task 2016-11-09T19:34:05.035356Z] 19:34:05     INFO -  Thread 0 (crashed)
[task 2016-11-09T19:34:05.035715Z] 19:34:05     INFO -   0  firefox!mozalloc_abort [mozalloc_abort.cpp:deabf7bc6526 : 33 + 0x0]
[task 2016-11-09T19:34:05.036045Z] 19:34:05     INFO -      rax = 0x0000000000627a08   rdx = 0x000000000041e1df
[task 2016-11-09T19:34:05.036356Z] 19:34:05     INFO -      rcx = 0x00007f61358a1fad   rbx = 0x00007f6135b74828
[task 2016-11-09T19:34:05.036611Z] 19:34:05     INFO -      rsi = 0x00007f6135b75a80   rdi = 0x00007f6135b74180
[task 2016-11-09T19:34:05.036918Z] 19:34:05     INFO -      rbp = 0x00007fff071a3250   rsp = 0x00007fff071a3240
[task 2016-11-09T19:34:05.037226Z] 19:34:05     INFO -       r8 = 0x00007f6136bcd740    r9 = 0x0000000000000043
[task 2016-11-09T19:34:05.037524Z] 19:34:05     INFO -      r10 = 0x00007fff071a2fd0   r11 = 0x00007f6135829b20
[task 2016-11-09T19:34:05.037788Z] 19:34:05     INFO -      r12 = 0x00007f6135b74828   r13 = 0x00007fff071a3498
[task 2016-11-09T19:34:05.038069Z] 19:34:05     INFO -      r14 = 0x00007fff071a32a0   r15 = 0x00007f612ccfe6a5
[task 2016-11-09T19:34:05.038370Z] 19:34:05     INFO -      rip = 0x0000000000405b9f
[task 2016-11-09T19:34:05.038811Z] 19:34:05     INFO -      Found by: given as instruction pointer in context
[task 2016-11-09T19:34:05.038952Z] 19:34:05     INFO -   1  libxul.so!NS_DebugBreak [nsDebugImpl.cpp:deabf7bc6526 : 449 + 0x8]
[task 2016-11-09T19:34:05.039262Z] 19:34:05     INFO -      rbx = 0x00007f612cba04f0   rbp = 0x00007fff071a36c0
[task 2016-11-09T19:34:05.039397Z] 19:34:05     INFO -      rsp = 0x00007fff071a3260   r12 = 0x00007f6135b74828
[task 2016-11-09T19:34:05.044135Z] 19:34:05     INFO -      r13 = 0x00007fff071a3498   r14 = 0x00007fff071a32a0
[task 2016-11-09T19:34:05.044224Z] 19:34:05     INFO -      r15 = 0x00007f612ccfe6a5   rip = 0x00007f6128ae8e92
[task 2016-11-09T19:34:05.044263Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.045032Z] 19:34:05     INFO -   2  libxul.so!mozilla::BlockingResourceBase::CheckAcquire [BlockingResourceBase.cpp:deabf7bc6526 : 307 + 0x22]
[task 2016-11-09T19:34:05.045091Z] 19:34:05     INFO -      rbx = 0x00007fff071a36e0   rbp = 0x00007fff071a3760
[task 2016-11-09T19:34:05.045168Z] 19:34:05     INFO -      rsp = 0x00007fff071a36d0   r12 = 0x00007f6135b74828
[task 2016-11-09T19:34:05.045214Z] 19:34:05     INFO -      r13 = 0x00007fff071a36d8   r14 = 0x00007fff071a3700
[task 2016-11-09T19:34:05.045949Z] 19:34:05     INFO -      r15 = 0x000001584a8eeaa5   rip = 0x00007f6128b7be68
[task 2016-11-09T19:34:05.046001Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.046089Z] 19:34:05     INFO -   3  libxul.so!mozilla::OffTheBooksMutex::Lock [BlockingResourceBase.cpp:deabf7bc6526 : 381 + 0x5]
[task 2016-11-09T19:34:05.046855Z] 19:34:05     INFO -      rbx = 0x00007fff071a3790   rbp = 0x00007fff071a3780
[task 2016-11-09T19:34:05.046910Z] 19:34:05     INFO -      rsp = 0x00007fff071a3770   r12 = 0x00007fff071a37e0
[task 2016-11-09T19:34:05.046985Z] 19:34:05     INFO -      r13 = 0x00007f61355c1160   r14 = 0x00007f613556e9a0
[task 2016-11-09T19:34:05.047030Z] 19:34:05     INFO -      r15 = 0x000001584a8eeaa5   rip = 0x00007f6128b7be94
[task 2016-11-09T19:34:05.047685Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.047790Z] 19:34:05     INFO -   4  libxul.so!Sanity_Child [TestDeadlockDetector.cpp:deabf7bc6526 : 66 + 0x8]
[task 2016-11-09T19:34:05.047864Z] 19:34:05     INFO -      rbx = 0x00007fff071a3790   rbp = 0x00007fff071a37c0
[task 2016-11-09T19:34:05.048041Z] 19:34:05     INFO -      rsp = 0x00007fff071a3790   r12 = 0x00007fff071a37e0
[task 2016-11-09T19:34:05.048109Z] 19:34:05     INFO -      r13 = 0x00007f61355c1160   r14 = 0x00007f613556e9a0
[task 2016-11-09T19:34:05.048282Z] 19:34:05     INFO -      r15 = 0x000001584a8eeaa5   rip = 0x00007f612b5d4e26
[task 2016-11-09T19:34:05.048347Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.048488Z] 19:34:05     INFO -   5  libxul.so!DeadlockDetectorTest_SanityDeathTest_Test::TestBody [TestDeadlockDetector.cpp:deabf7bc6526 : 79 + 0x5]
[task 2016-11-09T19:34:05.048561Z] 19:34:05     INFO -      rbx = 0x00007fff071a37f0   rbp = 0x00007fff071a38a0
[task 2016-11-09T19:34:05.048629Z] 19:34:05     INFO -      rsp = 0x00007fff071a37d0   r12 = 0x00007fff071a37e0
[task 2016-11-09T19:34:05.048779Z] 19:34:05     INFO -      r13 = 0x00007f61355c1160   r14 = 0x00007f613556e9a0
[task 2016-11-09T19:34:05.048846Z] 19:34:05     INFO -      r15 = 0x000001584a8eeaa5   rip = 0x00007f612b5d5f12
[task 2016-11-09T19:34:05.049208Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.049348Z] 19:34:05     INFO -   6  libxul.so!testing::Test::Run [gtest.cc:deabf7bc6526 : 2162 + 0xf]
[task 2016-11-09T19:34:05.049419Z] 19:34:05     INFO -      rbx = 0x00007f611bdabcc0   rbp = 0x00007fff071a38c0
[task 2016-11-09T19:34:05.049557Z] 19:34:05     INFO -      rsp = 0x00007fff071a38b0   r12 = 0x00007f61355c1160
[task 2016-11-09T19:34:05.049625Z] 19:34:05     INFO -      r13 = 0x00007f61355c1160   r14 = 0x00007f613556e9a0
[task 2016-11-09T19:34:05.049740Z] 19:34:05     INFO -      r15 = 0x000001584a8eeaa5   rip = 0x00007f612b644104
[task 2016-11-09T19:34:05.049804Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.050053Z] 19:34:05     INFO -   7  libxul.so!testing::TestInfo::Run [gtest.cc:deabf7bc6526 : 2338 + 0x8]
[task 2016-11-09T19:34:05.050194Z] 19:34:05     INFO -      rbx = 0x00007f61355ed7c0   rbp = 0x00007fff071a3910
[task 2016-11-09T19:34:05.050265Z] 19:34:05     INFO -      rsp = 0x00007fff071a38d0   r12 = 0x00007f611bdabcc0
[task 2016-11-09T19:34:05.050331Z] 19:34:05     INFO -      r13 = 0x00007f61355c1160   r14 = 0x00007f613556e9a0
[task 2016-11-09T19:34:05.050474Z] 19:34:05     INFO -      r15 = 0x000001584a8eeaa5   rip = 0x00007f612b644206
[task 2016-11-09T19:34:05.050537Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.050610Z] 19:34:05     INFO -   8  libxul.so!testing::TestCase::Run [gtest.cc:deabf7bc6526 : 2445 + 0xd]
[task 2016-11-09T19:34:05.051005Z] 19:34:05     INFO -      rbx = 0x00007f613556dba0   rbp = 0x00007fff071a3950
[task 2016-11-09T19:34:05.051090Z] 19:34:05     INFO -      rsp = 0x00007fff071a3920   r12 = 0x00007f61355c1160
[task 2016-11-09T19:34:05.051181Z] 19:34:05     INFO -      r13 = 0x00007f613556e9a0   r14 = 0x000001584a8eeaa5
[task 2016-11-09T19:34:05.051250Z] 19:34:05     INFO -      r15 = 0x0000000000000001   rip = 0x00007f612b6442af
[task 2016-11-09T19:34:05.051343Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.051497Z] 19:34:05     INFO -   9  libxul.so!testing::internal::UnitTestImpl::RunAllTests [gtest.cc:deabf7bc6526 : 4237 + 0x15]
[task 2016-11-09T19:34:05.051570Z] 19:34:05     INFO -      rbx = 0x00007f61355c1160   rbp = 0x00007fff071a39c0
[task 2016-11-09T19:34:05.051936Z] 19:34:05     INFO -      rsp = 0x00007fff071a3960   r12 = 0x00007f613556e9a0
[task 2016-11-09T19:34:05.052008Z] 19:34:05     INFO -      r13 = 0x0000000000000000   r14 = 0x0000000000000001
[task 2016-11-09T19:34:05.052075Z] 19:34:05     INFO -      r15 = 0x0000000000000000   rip = 0x00007f612b64491d
[task 2016-11-09T19:34:05.052167Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.052241Z] 19:34:05     INFO -  10  libxul.so!testing::UnitTest::Run [gtest.cc:deabf7bc6526 : 2145 + 0x8]
[task 2016-11-09T19:34:05.052311Z] 19:34:05     INFO -      rbx = 0x00007f61355c1160   rbp = 0x00007fff071a39e0
[task 2016-11-09T19:34:05.052469Z] 19:34:05     INFO -      rsp = 0x00007fff071a39d0   r12 = 0x00007fff071a3a18
[task 2016-11-09T19:34:05.052552Z] 19:34:05     INFO -      r13 = 0x00007fff071a3a30   r14 = 0x0000000000000000
[task 2016-11-09T19:34:05.052682Z] 19:34:05     INFO -      r15 = 0x00007fff071a3a10   rip = 0x00007f612b6449ff
[task 2016-11-09T19:34:05.052743Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.052816Z] 19:34:05     INFO -  11  libxul.so!mozilla::RunGTestFunc [GTestRunner.cpp:deabf7bc6526 : 118 + 0xd]
[task 2016-11-09T19:34:05.052980Z] 19:34:05     INFO -      rbx = 0x00007fff071a3a38   rbp = 0x00007fff071a3ab0
[task 2016-11-09T19:34:05.053051Z] 19:34:05     INFO -      rsp = 0x00007fff071a39f0   r12 = 0x00007fff071a3a18
[task 2016-11-09T19:34:05.053118Z] 19:34:05     INFO -      r13 = 0x00007fff071a3a30   r14 = 0x0000000000000000
[task 2016-11-09T19:34:05.053236Z] 19:34:05     INFO -      r15 = 0x00007fff071a3a10   rip = 0x00007f612b646789
[task 2016-11-09T19:34:05.053296Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.053371Z] 19:34:05     INFO -  12  libxul.so!XREMain::XRE_mainStartup [nsAppRunner.cpp:deabf7bc6526 : 3743 + 0x2]
[task 2016-11-09T19:34:05.053719Z] 19:34:05     INFO -      rbx = 0x00007fff071a3c20   rbp = 0x00007fff071a3cf0
[task 2016-11-09T19:34:05.053785Z] 19:34:05     INFO -      rsp = 0x00007fff071a3ac0   r12 = 0x00007f6126c73080
[task 2016-11-09T19:34:05.053851Z] 19:34:05     INFO -      r13 = 0x00007fff071a3d28   r14 = 0x00007fff071a3d20
[task 2016-11-09T19:34:05.053941Z] 19:34:05     INFO -      r15 = 0x0000000000000000   rip = 0x00007f612afd450e
[task 2016-11-09T19:34:05.053999Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.054073Z] 19:34:05     INFO -  13  libxul.so!XREMain::XRE_main [nsAppRunner.cpp:deabf7bc6526 : 4585 + 0xb]
[task 2016-11-09T19:34:05.054249Z] 19:34:05     INFO -      rbx = 0x00007fff071a3d98   rbp = 0x00007fff071a3d70
[task 2016-11-09T19:34:05.054333Z] 19:34:05     INFO -      rsp = 0x00007fff071a3d00   r12 = 0x00007fff071a3e08
[task 2016-11-09T19:34:05.054441Z] 19:34:05     INFO -      r13 = 0x00007fff071a3d28   r14 = 0x00007fff071a3d20
[task 2016-11-09T19:34:05.054508Z] 19:34:05     INFO -      r15 = 0x0000000000000000   rip = 0x00007f612afd8684
[task 2016-11-09T19:34:05.054567Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.054795Z] 19:34:05     INFO -  14  libxul.so!XRE_main [nsAppRunner.cpp:deabf7bc6526 : 4691 + 0x5]
[task 2016-11-09T19:34:05.054865Z] 19:34:05     INFO -      rbx = 0x00007fff071a3d98   rbp = 0x00007fff071a3f60
[task 2016-11-09T19:34:05.054994Z] 19:34:05     INFO -      rsp = 0x00007fff071a3d80   r12 = 0x0000000000000002
[task 2016-11-09T19:34:05.055061Z] 19:34:05     INFO -      r13 = 0x00007fff071a5128   r14 = 0x00007fff071a3fd0
[task 2016-11-09T19:34:05.055129Z] 19:34:05     INFO -      r15 = 0x00007fff071a3fb8   rip = 0x00007f612afd89a2
[task 2016-11-09T19:34:05.055255Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.055326Z] 19:34:05     INFO -  15  firefox!do_main [nsBrowserApp.cpp:deabf7bc6526 : 282 + 0x6]
[task 2016-11-09T19:34:05.055393Z] 19:34:05     INFO -      rbx = 0x00007fff071a5128   rbp = 0x00007fff071a5000
[task 2016-11-09T19:34:05.055517Z] 19:34:05     INFO -      rsp = 0x00007fff071a3f70   r12 = 0x0000000000000002
[task 2016-11-09T19:34:05.055605Z] 19:34:05     INFO -      r13 = 0x00007f6135557840   r14 = 0x00007fff071a3fb0
[task 2016-11-09T19:34:05.055674Z] 19:34:05     INFO -      r15 = 0x00007fff071a3fb8   rip = 0x0000000000405a68
[task 2016-11-09T19:34:05.055733Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.055827Z] 19:34:05     INFO -  16  firefox!main [nsBrowserApp.cpp:deabf7bc6526 : 415 + 0x12]
[task 2016-11-09T19:34:05.055893Z] 19:34:05     INFO -      rbx = 0x00007fff071a5128   rbp = 0x00007fff071a5040
[task 2016-11-09T19:34:05.055960Z] 19:34:05     INFO -      rsp = 0x00007fff071a5010   r12 = 0x0000000000000002
[task 2016-11-09T19:34:05.056061Z] 19:34:05     INFO -      r13 = 0x000005ac27c5e1ef   r14 = 0x00007fff071a5140
[task 2016-11-09T19:34:05.056129Z] 19:34:05     INFO -      r15 = 0x0000000000000000   rip = 0x0000000000404d67
[task 2016-11-09T19:34:05.056189Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.056351Z] 19:34:05     INFO -  17  libc-2.15.so + 0x217ed
[task 2016-11-09T19:34:05.056550Z] 19:34:05     INFO -      rbx = 0x0000000000000000   rbp = 0x0000000000000000
[task 2016-11-09T19:34:05.056757Z] 19:34:05     INFO -      rsp = 0x00007fff071a5050   r12 = 0x0000000000404f08
[task 2016-11-09T19:34:05.056929Z] 19:34:05     INFO -      r13 = 0x00007fff071a5120   r14 = 0x0000000000000000
[task 2016-11-09T19:34:05.057234Z] 19:34:05     INFO -      r15 = 0x0000000000000000   rip = 0x00007f61357dd7ed
[task 2016-11-09T19:34:05.057348Z] 19:34:05     INFO -      Found by: call frame info
[task 2016-11-09T19:34:05.057564Z] 19:34:05     INFO -  18  firefox!MOZ_ReportAssertionFailure [Assertions.h:deabf7bc6526 : 170 + 0x5]
[task 2016-11-09T19:34:05.057775Z] 19:34:05     INFO -      rsp = 0x00007fff071a5070   rip = 0x0000000000404d12
[task 2016-11-09T19:34:05.057950Z] 19:34:05     INFO -      Found by: stack scanning
Flags: needinfo?(erahm)
I think this is just the test harness being upset that a minidump was left around by the deathtest. Disabling the crash reporter should help.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e1f5ccf8da96cf842f2c9cac97f1501cc1090fa
Flags: needinfo?(erahm)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7714324d5082f4853277f8576dd838414f84030
Bug 1313488 - Part 0: Adding missing includes. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/e27050b02d69b88e19e0dcd151916f78259f9bb1
Bug 1313488 - Part 1: Convert XPCOM test TestDeadlockDetector to a gtest. r=froydnj

Comment 14

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a7714324d508
https://hg.mozilla.org/mozilla-central/rev/e27050b02d69
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.