Convert XPCOM test TestDeadlockDetectorScalability to a gtest

RESOLVED FIXED in Firefox 52

Status

()

Core
XPCOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(2 attachments)

Convert xpcom/tests/TestDeadlockDetectorScalability.cpp to a gtest and move to xpcom/tests/gtest/.
Created attachment 8807380 [details] [diff] [review]
Part 1: Remove dead code

MozReview-Commit-ID: HSS4Sf7O1I6
Attachment #8807380 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Created attachment 8807381 [details] [diff] [review]
Part 2: Convert DeadlockDetectorScalability to a gtest

This converts the tests to gtests. Most of them are just runtime tests and just
hava dummy assertion that everything ran. One test remains disabled, although
it's still built-in. You can run the disabled test with the following command:

> GTEST_ALSO_RUN_DISABLED_TESTS=1 ./mach gtest DeadlockDetectorScalability.*

MozReview-Commit-ID: 57rxjiZKjQ6
Attachment #8807381 - Flags: review?(nfroyd)
Attachment #8807380 - Flags: review?(nfroyd) → review+
Attachment #8807381 - Flags: review?(nfroyd) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/01800003ec3b043995e4ec1daaaf827e7ee2bbee for OS X builds being silly and continuing to burn like https://treeherder.mozilla.org/logviewer.html#?job_id=38802396&repo=mozilla-inbound even after the one where they started doing it was backed out for something else.
Testing fix in bug 1313489, comment 12.
Flags: needinfo?(erahm)

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fd51f48870d9
https://hg.mozilla.org/mozilla-central/rev/03fc16d0df1b
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.