1313490 - Remove expression closures from our tests

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

Before we can disable expression closures in Nightly we have to first remove all uses of expression closures from our JS tests. (Of course unless we actually *want* to test expression closures in a test)

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Part 1: Remove unnecessary expression closure from jit-test.

Changed to function expression or arrow function in tests that doesn't test parser.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Part 2: Remove unnecessary expression closure from jstests.

same for jstests

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Part 3: Remove expression closure from dom/.

expression closure is used to test warning there.
we can use "statement after return" instead.

Comment 4

[Tom S [:evilpie]]

Comment on attachment 8813500 [details] [diff] [review]
Part 1: Remove unnecessary expression closure from jit-test.

Review of attachment 8813500 [details] [diff] [review]:
-----------------------------------------------------------------

There a bunch more cases where `return` would be unnecessary, but considering that most tests look like fuzz tests anyway we can just preserve the current behavior more closely.

::: js/src/jit-test/tests/arguments/defaults-destructuring-expression-closure.js
@@ +2,5 @@
> +  return (
> +    assertEq(a, 1),
> +    assertEq(b, bIs),
> +    assertEq(c, cIs),
> +    assertEq(d, dIs)

Remove the return and () around the asserts.

::: js/src/jit-test/tests/baseline/bug852801.js
@@ -13,5 @@
>      for (var i=0; i<lines.length; i++)
>  	print (STATUS + lines[i]);
>  }
>  function printBugNumber (num) {}
> -function toPrinted(value)

That was confusing

Comment 5

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8aee096b3c4b3780b5d1a61d814bfe383664e285
Bug 1313490 - Part 1: Remove unnecessary expression closure from jit-test. r=evilpie

https://hg.mozilla.org/integration/mozilla-inbound/rev/64a9c8f9d503f56b914566f6943cf084381e96fe
Bug 1313490 - Part 2: Remove unnecessary expression closure from jstests. r=evilpie

https://hg.mozilla.org/integration/mozilla-inbound/rev/349bfd47d48b4af6eb1b8d8e1485d928e65606aa
Bug 1313490 - Part 3: Remove expression closure from dom/. r=mrbkap

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8aee096b3c4b
https://hg.mozilla.org/mozilla-central/rev/64a9c8f9d503
https://hg.mozilla.org/mozilla-central/rev/349bfd47d48b