Rename "Apps & Hacks" on firefox/developer

RESOLVED FIXED

Status

www.mozilla.org
Pages & Content
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: hoosteeno, Assigned: jpetto)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

44 bytes, text/x-github-pull-request
Details | Review | Splinter Review
We're renaming the Apps & Hacks newsletter. We should rename it on the /firefox/developer page:

https://www.mozilla.org/en-US/firefox/developer/

We should replace "Apps & Hacks" with "Mozilla Developer Newsletter":

https://github.com/mozilla/bedrock/blob/5417f5a3470c0612a8bda83d889429cab530bca6/bedrock/firefox/templates/firefox/developer.html#L225
@jdavis, the code here...

https://github.com/mozilla/bedrock/blob/5417f5a3470c0612a8bda83d889429cab530bca6/bedrock/firefox/templates/firefox/developer.html#L225

...does some switching to accommodate en- and es- locales. I believe this new newsletter is en-only, though. 

1) Correct?
2) If so, should we just eliminate the Spanish version?
Flags: needinfo?(jdavis)
(Assignee)

Comment 2

a year ago
There are a couple more instances of the old title/description in bedrock [1]. These should probably be updated as well?

[1] https://github.com/mozilla/bedrock/search?utf8=%E2%9C%93&q=%22Firefox+Apps%22&type=Code

Comment 3

a year ago
Suggest you remove the HTML/Text option too so it is consistent with the other sign-ups. It is also located here too  - https://marketplace.firefox.com/developers/submit/

@jdavis would you add to the email landscape map https://www.lucidchart.com/documents/edit/fe6fd90a-ac65-42da-bce1-c70f40253fb7
Hello!

Yes, this page, and the other instances should be updated with the new name. 

You can take away the "English" language drop down (as long as you add in "English Only" to the newsletter signup form.  I've taken away the ES option from drop down (this is controlled in the Basket admin).



:jpetto - for the other instances of where it's found in Bedrock:


1) bedrock/firefox/templates/firefox/developer.html


is this template used on any other page besides:

https://www.mozilla.org/en-US/firefox/developer/

If so, can you let me know those URLs? And they should be updated.



2) bedrock/newsletter/basket_data.json

I think this is controlled by the Basket Admin which I just updated this week. Can you confirm?



3)docs/newsletters.rst 

Looks like it's a form that's used as an iframe on some other pages. Do you know what pages this iframe exists?

I think it (previously) existed here:
https://hacks.mozilla.org/newsletter/

I'm unsure how people get to this URL, but it would be good to update this with the new opt-in language (and remove the blurbs about supporting it in Spanish).



Please note: these instances should not be updated until we have the new welcome & confirm emails set up (early next week)



AND - Thank you for filing this bug! I had no idea that this URL existed! I'm adding it to the email landscape map & audit doc: https://docs.google.com/document/d/1KGThD9AMio8Z9vJXqg6qWOo5eJM3yw9gvHEXkPG20ys/edit#bookmark=id.4i92lksa50hp


If you know of other sources that I do not have listed there, please let me know.
Flags: needinfo?(jdavis)
(Assignee)

Updated

a year ago
Assignee: nobody → jon
(Assignee)

Comment 5

a year ago
1) bedrock/firefox/templates/firefox/developer.html

Currently on /firefox/developer/, locales other than en-* and es-* get a signup for the mozilla-and-you newsletter [1].

Should we keep this split, showing the app-dev newsletter for en-* users and mozilla-and-you for all others? If so, I don't think we need the "English only" copy.

2) bedrock/newsletter/basket_data.json

:jgmize just submitted a PR that updates /newsletter/basket_data.json [2]. Should be good there now.

3) docs/newsletters.rst

Also unsure how people might get to the URL referenced in the docs. Asked in IRC, and we recently removed the embedable URL [3], so I'm going to say it's no longer an issue. I think we just need to update the docs.


[1] https://www.mozilla.org/fr/firefox/developer/
[2] https://github.com/mozilla/bedrock/pull/4441
[3] https://github.com/mozilla/bedrock/pull/4406
Flags: needinfo?(jdavis)
(In reply to Jon Petto [:jpetto] from comment #5)
> 1) bedrock/firefox/templates/firefox/developer.html
> 
> Currently on /firefox/developer/, locales other than en-* and es-* get a
> signup for the mozilla-and-you newsletter [1].
> 
> Should we keep this split, showing the app-dev newsletter for en-* users and
> mozilla-and-you for all others? If so, I don't think we need the "English
> only" copy.

Sweet. I agree. 

To confirm: Please update the split so that it shows the "app-dev" newsletter for en-*, all other locales should show en-*.

The tricky part will be if you don't want to show the language field on the "app-dev" form on en-*.  (:hoosteeno - this would be a stellar test to see if showing the language field with only "English" as an option on en-* causes less people to fill out the form.)

The language field for "mozilla-and-you" should always show.
Flags: needinfo?(jdavis)
(Assignee)

Comment 7

a year ago
We have a built-in mechanism to conditionally hide the language selector, so not tricky at all. :)
(Assignee)

Comment 8

a year ago
Created attachment 8806029 [details] [review]
GitHub PR
Ain't you fancy! That's awesome! :D

Comment 10

a year ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/25418e8dd65d0b1af6e6f41fddefb0fd53eca408
[fix bug 1313508] Update /firefox/developer/ newsletter.

https://github.com/mozilla/bedrock/commit/02a576a1a56f4d035a012dae8a3b95912330ac80
Merge pull request #4444 from jpetto/bug-1313508-app-dev-newsletter-updates

[fix bug 1313508] Update /firefox/developer/ newsletter.

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.