1313571 - Intermittent browser/components/sessionstore/test/browser_undoCloseById.js | The last closed object is a window - Got tab, expected window

Status: RESOLVED DUPLICATE of bug 1309880

(Firefox :: Session Restore, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=5791177&repo=autoland

https://queue.taskcluster.net/v1/task/ZiNJTH1VSFicAUZsdUybBQ/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Mike de Boer [:mikedeboer]]

Bob, I was thinking about this some more and I think we put the timeout in the wrong place. The `promiseBrowserLoaded` is already spinning the event loop when the promise resolved, but when we close the tab we prolly need to spin it some more afterwards to make sure that the state is updated in the sessionstore. Can you take a look at that?

Comment 2

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1313571 - Fix Intermittent browser/components/sessionstore/test/browser_undoCloseById.js,

Review commit: https://reviewboard.mozilla.org/r/89294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89294/

Comment 3

[Bob Silverberg [:bsilverberg]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e0f7d04ea3e

Comment 4

[Bob Silverberg [:bsilverberg]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=126a78aaf993

Comment 5

[Bob Silverberg [:bsilverberg]]

The change causing this intermittent was backed out, and I have included a fix for this in bug 1309880, so I am going to mark this as a dupe of that for now.

Comment 6

[Intermittent Failures Robot]

4 failures in 1008 pushes (0.004 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 3
* mozilla-inbound: 1

Platform breakdown:
* linux64: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313571&startday=2017-07-24&endday=2017-07-30&tree=all

Comment 7

[Intermittent Failures Robot]

1 failures in 912 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* linux32-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313571&startday=2017-10-23&endday=2017-10-29&tree=all

Comment 8

[Intermittent Failures Robot]

1 failures in 849 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313571&startday=2017-11-06&endday=2017-11-12&tree=all