Dotted line for the comment in diff view looks like off by one line

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: arai, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Created attachment 8805501 [details]
Dotted line in diff view, actual result and expected result

When I add a comment to diff view, a dotted line is rendered above the line.
It looks like the comment is displayed at the dotted line's position, that is off by one line (-1) from actual position.

see the attached image for what I mean.
thanks for the report (bonus thanks for a clear problem/recommendation screenshot!).

the dotted line is rendered at the start of the selected range, which is important when multiple lines are selected for a comment, but i do agree it's not the right thing to do when a single line is selected.

that said it's going away this week with the landing of bug 1115707, which renders the comments inline below the selected range.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.