1313623 - ADB Helper 0.8.8 fails to install through WebIDE

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[pasi]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20161019084923

Steps to reproduce:

Go to Tools > Developer Tools > WebIDE. Select "Install ADB Helper". Click "Install" in the "ADB Helper Add-on" section.


Actual results:

The download starts and once the progress bar is at 100 % you get an error message "Operation failed: Download failed" and a button saying "Troubleshooting".


Expected results:

The extension should install.

Comment 1

[pasi]

I did some poking around and found from the source code that WebIDE is trying to download the extension from https://ftp.mozilla.org/pub/labs/fxos-simulator/adb-helper/win32/adbhelper-win32-latest.xpi . At the moment the latest version is 0.8.8. When I tried to install this extension manually I got an error "Firefox has prevented this site from installing an unverified add-on". When I tried installing the previous version 0.8.7 it worked as expected.

Comment 2

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 49.0.2 (20161019084923), Firefox 50.0b11 (20161027110534), Firefox 51.0a2 (2016-10-31) and Firefox 52.0a1 (2016-10-31) under Windows 10 64-bit and Mac Ubuntu 12.04 64-bit.
ADB Helper 0.8.8 fails to install through WebIDE because it is unsigned.


Browser Console errors: 
1477924869735	addons.xpi	WARN	Add-on [e-mail] is not correctly signed.
1477924869736	addons.xpi	WARN	Download of https://ftp.mozilla.org/pub/mozilla.org/labs/fxos-simulator/adb-helper/win32/adbhelper-win32-latest.xpi failed: signature is required but missing
Operation failed: Download failedwebide.js:354:5

Comment 3

[Andy McKay]

Assuming the

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Ah yes, my mistake, I forgot to sign 0.8.8.

I'll spin up 0.8.9 with signing.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Okay, 0.8.9 has been released with signatures.  Sorry for the error.

It may take up to 24 hours for the new version to appear.

Comment 6

[Vasilica Tamas, QA [:vtamas]]

Verified fixed on Firefox 52.0a1 (2016-11-01), Firefox 51.0a2 (2016-11-01), Firefox 50.0b11 (20161027110534) and Firefox 49.0.2 (20161019084923) under Windows 10 64-bit and Ubuntu 12.04 64-bit.


I’ve also filed a new issue which reproduces only on Firefox 50.0b11 and Firefox 49.0.2, because these versions do not support many add-ons with e10s enabled, and it refers to the fact that the user is not announced to restart the browser in order to complete the installation process: Bug 1314582