don't make any change to database if row hasn't actually changed

NEW
Unassigned

Status

P3
normal
2 years ago
8 months ago

People

(Reporter: bhearsum, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=python][ready])

(Reporter)

Description

2 years ago
After we enabled the change notifier we found at least one case where automation repeatedly makes the same change to the database many times. This is silly, and unnecessarily invalidates caches. We should try to make clients smarter about this where we can, but we can also do better on the backend and simply check if things will change prior to making a write.

We should watch out for potential performance penalties when it comes to Releases. Single locale updates already need to retrieve the current version of the blob before changing it, but updates to Release blobs that intend to replace the full contents may not already retrieve the entire blob already.
(Reporter)

Updated

2 years ago
Priority: -- → P3
Whiteboard: [lang=python][ready]

Updated

2 years ago
Assignee: nobody → ashish.sareen95
(Reporter)

Comment 1

a year ago
Ashish, are you still planning to look at this?
Flags: needinfo?(ashish.sareen95)

Comment 2

a year ago
Not at the moment. Still busy with the gsoc project. So, I'll unassign the bug for now.
Flags: needinfo?(ashish.sareen95)

Updated

a year ago
Assignee: ashish.sareen95 → nobody

Comment 3

a year ago
Can I try taking this on ?
(Reporter)

Comment 4

a year ago
Yup, go right ahead.
Assignee: nobody → svezauzeto12
(Reporter)

Comment 5

a year ago
(In reply to Ben Hearsum (:bhearsum) from comment #4)
> Yup, go right ahead.

Any progress here Tomislav?
Flags: needinfo?(svezauzeto12)
(Reporter)

Comment 6

a year ago
Unassigning due to inactivity.
Assignee: svezauzeto12 → nobody
(Reporter)

Updated

a year ago
Flags: needinfo?(svezauzeto12)
Hey!! Can you assign this one to me?? I would like to work on it.
(In reply to Vikas Prasad Mahato from comment #7)
> Hey!! Can you assign this one to me?? I would like to work on it.

Hi! Make a pull request and then we can change the assignment.
Sorry I was busy due to college. I would like to continue working on this bug. Can you give some hints on how should I proceed?
Hey! I am still interested in working on this bug. However I need some pointers on reproducing the bug.
You need to log in before you can comment on or make changes to this bug.