Closed Bug 1313632 Opened 7 years ago Closed 7 years ago

Remove legacy OggReader

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: kaku, Assigned: jya)

References

Details

Attachments

(2 files)

Bug 1313632: P1. Remove unused OggReader.
58 bytes, text/x-review-board-request
kaku
: review+
Details
Bug 1313632: P2. Cleaner Ogg related headers.
58 bytes, text/x-review-board-request
kaku
: review+
Details 
Once we remove this from the code base, we can then remove MediaDecoder::DispatchSetStartTime().
Depends on: 1309516
Blocks: 1313635
Assignee: nobody → kaku
Assignee: kaku → jyavenard
See Also: → 1316205
Blocks: 1316211
Comment on attachment 8808864 [details]
Bug 1313632: P1. Remove unused OggReader.

https://reviewboard.mozilla.org/r/91596/#review91526
Attachment #8808864 - Flags: review?(kaku) → review+
Comment on attachment 8808865 [details]
Bug 1313632: P2. Cleaner Ogg related headers.

https://reviewboard.mozilla.org/r/91598/#review91522

::: dom/media/flac/FlacFrameParser.cpp:47
(Diff revision 1)
> +FlacFrameParser::~FlacFrameParser()
> +{
> +}

Why do we add a destructor but doing nothing?
Attachment #8808865 - Flags: review?(kaku) → review+
Comment on attachment 8808865 [details]
Bug 1313632: P2. Cleaner Ogg related headers.

https://reviewboard.mozilla.org/r/91598/#review91522

> Why do we add a destructor but doing nothing?

This is so I can use a forward declaration for some class types. Otherwise the default destructor wouldnt know how to deal with the nsAutoPtr and would cause a compilation warning about undefined behaviour. 

That way the destructor is defined and called where it has the full type definition
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/864ab5efde71
P1. Remove unused OggReader. r=kaku
https://hg.mozilla.org/integration/autoland/rev/87e4efe2210f
P2. Cleaner Ogg related headers. r=kaku
https://hg.mozilla.org/mozilla-central/rev/864ab5efde71
https://hg.mozilla.org/mozilla-central/rev/87e4efe2210f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.