1313632 - Remove legacy OggReader

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Tzuhao Kuo [:kaku]]

Once we remove this from the code base, we can then remove MediaDecoder::DispatchSetStartTime().

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1313632: P1. Remove unused OggReader.

Also remove related preference.

Review commit: https://reviewboard.mozilla.org/r/91596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91596/

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1313632: P2. Cleaner Ogg related headers.

Review commit: https://reviewboard.mozilla.org/r/91598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91598/

Comment 3

[Tzuhao Kuo [:kaku]]

Comment on attachment 8808864 [details]
Bug 1313632: P1. Remove unused OggReader.

https://reviewboard.mozilla.org/r/91596/#review91526

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8808865 [details]
Bug 1313632: P2. Cleaner Ogg related headers.

https://reviewboard.mozilla.org/r/91598/#review91522

::: dom/media/flac/FlacFrameParser.cpp:47
(Diff revision 1)
> +FlacFrameParser::~FlacFrameParser()
> +{
> +}

Why do we add a destructor but doing nothing?

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8808865 [details]
Bug 1313632: P2. Cleaner Ogg related headers.

https://reviewboard.mozilla.org/r/91598/#review91522

> Why do we add a destructor but doing nothing?

This is so I can use a forward declaration for some class types. Otherwise the default destructor wouldnt know how to deal with the nsAutoPtr and would cause a compilation warning about undefined behaviour. 

That way the destructor is defined and called where it has the full type definition

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/864ab5efde71
P1. Remove unused OggReader. r=kaku
https://hg.mozilla.org/integration/autoland/rev/87e4efe2210f
P2. Cleaner Ogg related headers. r=kaku

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/864ab5efde71
https://hg.mozilla.org/mozilla-central/rev/87e4efe2210f