1313715 - Avoid unnecessary use of PR_SetError() under security/apps/ and security/certverifier

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[:Cykesiopka]

The PR_SetError() + PR_GetError() pattern is error prone and unnecessary.

Comment 1

[:Cykesiopka]

Attachment: Bug 1313715 - Avoid unnecessary uses of PR_SetError() under security/apps/ and security/certverifier/.

The PR_SetError() + PR_GetError() pattern is error prone and unnecessary.

Also fixes Bug 1254403.

Review commit: https://reviewboard.mozilla.org/r/98084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98084/

Comment 2

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8817896 [details]
Bug 1313715 - Avoid unnecessary uses of PR_SetError() under security/apps/ and security/certverifier/.

https://reviewboard.mozilla.org/r/98084/#review98716

Cool - lgtm. Just the one comment.

::: security/apps/AppTrustDomain.cpp:166
(Diff revision 1)
>    }
>  
>    mTrustedRoot.reset(CERT_NewTempCertificate(CERT_GetDefaultCertDB(),
>                                               &trustedDER, nullptr, false, true));
>    if (!mTrustedRoot) {
> -    return SECFailure;
> +    return NS_ERROR_OUT_OF_MEMORY;

We probably actually want to return mozilla::psm::GetXPCOMFromNSSError(PR_GetError()); here since this could be a more informative error (e.g. reused issuer/serial).

::: security/certverifier/NSSCertDBTrustDomain.cpp
(Diff revision 1)
>  
>  static const uint64_t ServerFailureDelaySeconds = 5 * 60;
>  
>  namespace mozilla { namespace psm {
>  
> -const char BUILTIN_ROOTS_MODULE_DEFAULT_NAME[] = "Builtin Roots Module";

Looks like this also takes care of bug 1254403.

Comment 3

[:Cykesiopka]

Comment on attachment 8817896 [details]
Bug 1313715 - Avoid unnecessary uses of PR_SetError() under security/apps/ and security/certverifier/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98084/diff/1-2/

Comment 4

[:Cykesiopka]

Thanks!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=08d39454dc79134fc49fe91876ec58f51b256aba

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/676ca54f13db
Avoid unnecessary uses of PR_SetError() under security/apps/ and security/certverifier/. r=keeler

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/676ca54f13db