Tests not found when run locally

RESOLVED FIXED in Firefox 52

Status

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jchen, Assigned: cmanchester)

Tracking

Version 3
mozilla52
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

At least for the robocop tests I was trying to run locally, mach always says tests not found. I think this is a regression from bug 1312520, more specifically inside `manifestparser.combine_fields`.

For robocop tests for example, `global_vars` has {'subsuite': 'robocop'}, and `local_vars` has {'subsuite': ''}. When we combine the fields, the empty subsuite field in `local_vars` ends up replacing the subsuite field in `global_vars`, and the test ends up with an empty subsuite field. Subsequently, we filter out the test because the empty subsuite does not match the expected subsuite 'robocop'.
Flags: needinfo?(cmanchester)
I see the issue. I have a provisional fix, although Andrew may have a better idea here.
Assignee: nobody → cmanchester
Flags: needinfo?(cmanchester)
Comment on attachment 8805620 [details]
Bug 1313716 - Don't provide a blank subsuite as a default in the manifestparser.

https://reviewboard.mozilla.org/r/89366/#review88580

Lgtm. I feel like there's some place this might come back to bite us, but doing this makes sense so I guess we can deal with that if it arises.
Attachment #8805620 - Flags: review?(ahalberstadt) → review+
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/425c0602ccb4
Don't provide a blank subsuite as a default in the manifestparser. r=ahal
https://hg.mozilla.org/mozilla-central/rev/425c0602ccb4
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
This patch breaks `./mach mochitest js/xpconnect/tests/chrome/test_xrayToJS.xul` when run locally.
Yeah, after landing this, we can't specify any targets for mochitest.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccdaf2b0cc9e69dd847551750acf5fb0e8e99f26
Backed out changeset 425c0602ccb4 (bug 1313716) for breaking mach mochitest. r=backout
Backed out for breaking mach mochitest
Status: RESOLVED → REOPENED
Flags: needinfo?(cmanchester)
Resolution: FIXED → ---
Duplicate of this bug: 1314022
Andrew, are you ok with this as a fixup? Sorry to just paste it here, mozreview isn't letting me push to this bug again.

diff --git a/testing/mozbase/manifestparser/manifestparser/filters.py b/testing/mozbase/m
--- a/testing/mozbase/manifestparser/manifestparser/filters.py
+++ b/testing/mozbase/manifestparser/manifestparser/filters.py
@@ -138,17 +138,17 @@ class subsuite(InstanceFilter):
                 else:
                     test['subsuite'] = ''
 
             # Filter on current subsuite
             if self.name is None:
                 if not test.get('subsuite'):
                     yield test
             else:
-                if test.get('subsuite') == self.name:
+                if test.get('subsuite', '') == self.name:
                     yield test
 
 
 class chunk_by_slice(InstanceFilter):
     """
     Basic chunking algorithm that splits tests evenly across total chunks.
 
     :param this_chunk: the current chunk, 1 <= this_chunk <= total_chunks
Flags: needinfo?(cmanchester) → needinfo?(ahalberstadt)
Yep looks good assuming it's tested. Fwiw, you can go to the parent review request and click re-open there (not from the child view), then it should let you re-push. I think there's already work underway to improve that UX.
Flags: needinfo?(ahalberstadt)
(In reply to Andrew Halberstadt [:ahal] from comment #14)
> Yep looks good assuming it's tested. Fwiw, you can go to the parent review
> request and click re-open there (not from the child view), then it should
> let you re-push. I think there's already work underway to improve that UX.

Aha, thanks!
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa43713a681d
Don't provide a blank subsuite as a default in the manifestparser. r=ahal
https://hg.mozilla.org/mozilla-central/rev/fa43713a681d
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.