Closed Bug 1313739 Opened 3 years ago Closed 3 years ago

Move TabGroup into its own file, separate from DocGroup

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: Nika, Assigned: Nika)

Details

Attachments

(1 file)

No description provided.
MozReview-Commit-ID: AndPWOBpkox
Attachment #8805635 - Flags: review?(bkelly)
Comment on attachment 8805635 [details] [diff] [review]
Move TabGroup into its own file, seperate from DocGroup

Review of attachment 8805635 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/DocGroup.h
@@ +13,5 @@
>  #include "nsTHashtable.h"
>  #include "nsString.h"
>  
>  #include "mozilla/RefPtr.h"
> +#include "mozilla/dom/TabGroup.h"

Why do you need the full include here instead of just a foreward declaration?  If you need this here you can get rid of the include in DocGroup.cpp.
Attachment #8805635 - Flags: review?(bkelly) → review+
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/531763d23d79
Move TabGroup into its own file, seperate from DocGroup, r=bkelly
https://hg.mozilla.org/mozilla-central/rev/531763d23d79
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.