Closed
Bug 1313775
Opened 8 years ago
Closed 8 years ago
Port Bug 1268733 to TB
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 52.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file, 1 obsolete file)
|
1.40 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
Patch coming up. Linux bustage seen here: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0ed838165d1cf26db32dbc7f41c09dfb879d326e
|
Assignee | |
Updated•8 years ago
|
Summary: Bug 1313726 - Port Bug 1268733 to TB → Port Bug 1268733 to TB
|
|
Assignee | |
Comment 1•8 years ago
|
||
Try here: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9ab25c4ce37151a33472d9337e7e736d6da79d26
Attachment #8805701 -
Flags: review?(aleth)
|
|
Assignee | |
Comment 2•8 years ago
|
||
That failed since the the M-C patch was already applied. Trying again: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ad241e164aaaeff21bdc12fee43a1f2eeb39381b
|
|
Assignee | |
Comment 3•8 years ago
|
||
OK, trying again, this time with Philipp's magic patch from bug 1154222: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1d770134325d40675bf1fadf55116e5040c381e6
|
|
Assignee | |
Comment 4•8 years ago
|
||
That actually worked. Is the patch OK like this, or do you prefer to copy the M-C hunk 1:1 like: +#if defined(MOZ_SANDBOX) +#if defined(XP_LINUX) +@BINPATH@/@DLL_PREFIX@mozsandbox@DLL_SUFFIX@ +#endif +#endif and not merge it like I've done?
|
|
Assignee | |
Comment 5•8 years ago
|
||
Attachment #8805747 -
Flags: review?(aleth)
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8805747 [details] [diff] [review] 1313775.patch (alternative) Review of attachment 8805747 [details] [diff] [review]: ----------------------------------------------------------------- It doesn't matter much in this case, but with files which we constantly have to port to from m-c, making them look as similar as possible can help. Thanks for the quick patch!
Attachment #8805747 -
Flags: review?(aleth) → review+
|
|
||
Updated•8 years ago
|
Attachment #8805701 -
Flags: review?(aleth)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8805701 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/95592499dd9487766b859dccdbaee2b794e694a5 Landed on closed/busted tree, try run here: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=f912cca79bb4d82348cc9a435f7127a0bd20652d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in
before you can comment on or make changes to this bug.
Description
•