1313825 - Investigate and enable the browser_UsageTelemetry_content_aboutHome.js test

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

This test was disabled due to intermittents, see: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=0a1486cf11b228e41d27499b79b1e3ea6be3e28f&selectedJob=38398438

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

fwiw, the AboutHomeLoadSnippetsCompleted is fired by the content process, so it would have been better to use ContentTaskUtils.waitForEvent. That said, that is unlikely to fix the problem.

At this point you likely need to add a bunch of debugging to the test, like checking that the ContentSearchController is alive, where we are in the about:home init and so on, to try to get a dump when it fails.

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: bug1313825.patch

(In reply to Marco Bonardo [::mak] from comment #1)
> fwiw, the AboutHomeLoadSnippetsCompleted is fired by the content process, so
> it would have been better to use ContentTaskUtils.waitForEvent. That said,
> that is unlikely to fix the problem.

This patch seems to fix the problem, see [1] (the failures don't relate to this test).
I tried to use |ContentTaskUtils.waitForEvent| but it gets stuck and never moves on. "AboutHomeLoadSnippetsCompleted" seems to be a chrome event: is this the reason?

[1] - https://treeherder.mozilla.org/#/jobs?repo=try&revision=847370d6a38a&selectedJob=30228334

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Alessio Placitelli [:Dexter] from comment #2)
> I tried to use |ContentTaskUtils.waitForEvent| but it gets stuck and never
> moves on. "AboutHomeLoadSnippetsCompleted" seems to be a chrome event: is
> this the reason?

I think it's more likely that the event fires before the listener is added. the event is created in content and bubbles up, indeed the addEventListener has the wantsUntrusted boolean set.
Btw, let's not fight windmills, a working solution is enough :)

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8806336 [details] [diff] [review]
bug1313825.patch

Review of attachment 8806336 [details] [diff] [review]:
-----------------------------------------------------------------

Let's see how this behaves.

Comment 5

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffd43dc2055f87b29c49390559d8edade1ff6479
Bug 1313825 - Fix and enable browser_UsageTelemetry_content_aboutHome.js. r=mak

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ffd43dc2055f

Comment 7

[Alessio Placitelli [:Dexter]]

Comment on attachment 8806336 [details] [diff] [review]
bug1313825.patch

Approval Request Comment
[Feature/regressing bug #]: This patch fixes and enables a test from bug 1303333. It needs to be uplifted together with that bug.
[User impact if declined]: None.
[Describe test coverage new/current, TreeHerder]: It enables a new test guards against data regressions due to changes in the FF code.
[Risks and why]: None.
[String/UUID change made/needed]: None

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8806336 [details] [diff] [review]
bug1313825.patch

This patch fixes a test error. Take it in 51 aurora.

Comment 9

[Alessio Placitelli [:Dexter]]

Aurora changeset: https://hg.mozilla.org/releases/mozilla-aurora/rev/5eb8dba92c23bcb330f481ba4faff54e1bf1bf57