1313846 - Compile with ASAN enabled fails because of uninitialized variable in lib/jar/jarfile.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[catdesk]

When running:

USE_ASAN=1 USE_64=1 make nss_build_all

Errors with:

make[2]: Entering directory '/home/user/dev/nss/lib/jar'
cc -o Linux3.16_x86_64_cc_glibc_PTH_ASAN_64_DBG.OBJ/jarfile.o -c -g -O1 -fPIC -DLINUX2_1 -m64 -pipe -ffunction-sections -fdata-sections -DLINUX -Dlinux -DHAVE_STRERROR -fsanitize=address  -fno-omit-frame-pointer -fno-optimize-sibling-calls -Wall -Werror -DXP_UNIX -DMOZILLA_CLIENT=1 -DDEBUG -UNDEBUG -DDEBUG_user -D_REENTRANT -DNSS_NO_INIT_SUPPORT -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DNSS_X86_OR_X64 -DNSS_X64 -I../../../dist/Linux3.16_x86_64_cc_glibc_PTH_ASAN_64_DBG.OBJ/include -I../../../dist/public/nss -I../../../dist/private/nss  jarfile.c
jarfile.c: In function ‘jar_listzip’:
jarfile.c:805:19: error: ‘it’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     if (phy && it == NULL)
                   ^
cc1: all warnings being treated as errors
../../coreconf/rules.mk:392: recipe for target 'Linux3.16_x86_64_cc_glibc_PTH_ASAN_64_DBG.OBJ/jarfile.o' failed

Comment 1

[catdesk]

Attachment: 0001-Bug-1313846-Declare-it-NULL-earlier.-r-franziskus.patch

Comment 2

[Franziskus Kiefer [:franziskus]]

Good catch! I'm not able to reproduce this but it is a bug and we should definitely fix it.
What compiler are you using?

Comment 3

[catdesk]

(In reply to Franziskus Kiefer [:fkiefer or :franziskus] from comment #2)
> Good catch! I'm not able to reproduce this but it is a bug and we should
> definitely fix it.
> What compiler are you using?

gcc (Debian 4.9.2-10) 4.9.2

Comment 4

[Franziskus Kiefer [:franziskus]]

(In reply to catdesk from comment #3)
> (In reply to Franziskus Kiefer [:fkiefer or :franziskus] from comment #2)
> > Good catch! I'm not able to reproduce this but it is a bug and we should
> > definitely fix it.
> > What compiler are you using?
> 
> gcc (Debian 4.9.2-10) 4.9.2

ugh, that's old ;) But 4.9 is ok to use.

I landed the patch as https://hg.mozilla.org/projects/nss/rev/b9ef971b94ab110302d49255339077bc1b4aed7f

I'm closing this one because it's fixed. But you could try to build it again and see if you find any other bugs of this type.