Port Bug 1310345 to mailnews

RESOLVED FIXED in Thunderbird 52.0

Status

MailNews Core
Backend
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: frg, Assigned: frg)

Tracking

unspecified
Thunderbird 52.0

Thunderbird Tracking Flags

(thunderbird51 unaffected, thunderbird52 affected, seamonkey2.48 unaffected, seamonkey2.49esr affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Suite compile currently fails because FindChildWithName changed from char16_t* to an nsAString& for argument 1.
(Assignee)

Comment 1

a year ago
Created attachment 8805791 [details] [diff] [review]
1313858-FindChildWithName.patch

Whoever is faster can review it. Hope that is all which is needed.
Attachment #8805791 - Flags: review?(jorgk)
Attachment #8805791 - Flags: review?(iann_bugzilla)

Comment 2

a year ago
Comment on attachment 8805791 [details] [diff] [review]
1313858-FindChildWithName.patch

Review of attachment 8805791 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I'm faster ;-)
Please land with r=jorgk a=bustage-fix CLOSED TREE DONTBUILD. Or I can land it.
I will trigger a try run for it once landed.
Attachment #8805791 - Flags: review?(jorgk)
Attachment #8805791 - Flags: review?(iann_bugzilla)
Attachment #8805791 - Flags: review+
(Assignee)

Comment 3

a year ago
Please wait. I just needed to file another bug 1313860. Not sure if all which is needed is a "false" as parameter there. Still compiling.

Comment 4

a year ago
https://hg.mozilla.org/comm-central/rev/77813df1499535e040fee3b34f217f0d5ead705e
Landed on closed/busted tree, try run here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2b410485bd8e70afab57575f8478eb107e85ca0c
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.