Closed Bug 1313860 Opened 3 years ago Closed 3 years ago

Port Bug 1301655 to mailnews. New parameter for getSelectedLocale.

Categories

(MailNews Core :: Internationalization, defect)

defect
Not set

Tracking

(thunderbird51 unaffected, thunderbird52 affected, seamonkey2.48 unaffected, seamonkey2.49esr affected)

RESOLVED FIXED
Thunderbird 52.0
Tracking Status
thunderbird51 --- unaffected
thunderbird52 --- affected
seamonkey2.48 --- unaffected
seamonkey2.49esr --- affected

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(1 file)

Suite compile currently fails because  an optional parameter to nsIChromeRegistry.getSelectedLocale added an optional parameter in bug 	1301655.
The specific changeset which changed this:

https://hg.mozilla.org/mozilla-central/rev/b6ab66ffae99
SeaMonkey compiled fine and didn't crash when getting messages and composing one but I didn't check deeply what the orginal bug changed so please take the patch with a grain of salt.
Attachment #8805794 - Flags: review?(rkent)
Attachment #8805794 - Flags: feedback?(jorgk)
Summary: Port Bug 1301655 to mailnews → Port Bug 1301655 to mailnews. New parameter for getSelectedLocale.
Comment on attachment 8805794 [details] [diff] [review]
1313860-getSelectedLocale.patch

Review of attachment 8805794 [details] [diff] [review]:
-----------------------------------------------------------------

I looked at https://hg.mozilla.org/mozilla-central/rev/b6ab66ffae99#l7.15 at it appears that all you need to do is add 'false' as you've done.

Please land with r=jorgk a=bustage-fix CLOSED TREE DONTBUILD.

This is the 4th concurrent bustage so we need to keep going to brace for any further bustage.
The other three are: Bug 1313775, bug 1313860 and bug 1313670.

Never mind Kent, he might not show up until Monday.

Give me a hoy on IRC when you're done.
Attachment #8805794 - Flags: review?(rkent)
Attachment #8805794 - Flags: review+
Attachment #8805794 - Flags: feedback?(jorgk)
https://hg.mozilla.org/comm-central/rev/6b8c7cd17855f7de5eccb0ea9efcd5dbccc68573
Landed on closed/busted tree, try run here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2b410485bd8e70afab57575f8478eb107e85ca0c
Assignee: nobody → frgrahl
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.