1313862 - Intermittent browser/modules/test/browser_CaptivePortalWatcher.js | The captive portal tab should be open in the background in the current window. - Didn't expect [object XULElement], but got it

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This tested got enabled on all platforms in bug 1279491 yesterday. If it fails too often (and on tier 1, current failure is on tier 2), the change to enable it globally will get backed out.

https://treeherder.mozilla.org/logviewer.html#?job_id=5880123&repo=autoland

[task 2016-10-29T14:59:59.422642Z] 14:59:59     INFO - Entering test bound bound test_detectedWithFocus
[task 2016-10-29T14:59:59.424352Z] 14:59:59     INFO - TEST-PASS | browser/modules/test/browser_CaptivePortalWatcher.js | There should be a captive portal tab in the window. - 
[task 2016-10-29T14:59:59.428853Z] 14:59:59     INFO - TEST-PASS | browser/modules/test/browser_CaptivePortalWatcher.js | There should be a captive portal notification in the window. - 
[task 2016-10-29T14:59:59.440429Z] 14:59:59     INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser_CaptivePortalWatcher.js | The captive portal tab should be open in the background in the current window. - Didn't expect [object XULElement], but got it
[task 2016-10-29T14:59:59.442651Z] 14:59:59     INFO - Stack trace:
[task 2016-10-29T14:59:59.445247Z] 14:59:59     INFO -     chrome://mochikit/content/browser-test.js:test_isnot:913
[task 2016-10-29T14:59:59.447577Z] 14:59:59     INFO -     chrome://mochitests/content/browser/browser/modules/test/browser_CaptivePortalWatcher.js:test_detectedWithFocus:147
[task 2016-10-29T14:59:59.449353Z] 14:59:59     INFO -     Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Bah, this was fixed in the first patch that landed for bug 1279491, but was missed in the second patch that landed after the first got backed out.

The fix is to wait for xul-window-visible after closing a browser window: https://reviewboard.mozilla.org/r/61676/diff/1-2#1

I'll upload a new patch with this fix.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1313862 - Wait for xul-window-visible after closing browser windows in browser_CaptivePortalWatcher.js.

Review commit: https://reviewboard.mozilla.org/r/89448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89448/

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8805799 [details]
Bug 1313862 - Wait for xul-window-visible after closing browser windows in browser_CaptivePortalWatcher.js.

https://reviewboard.mozilla.org/r/89448/#review89310

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8309234a1e7
Wait for xul-window-visible after closing browser windows in browser_CaptivePortalWatcher.js. r=MattN

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c8309234a1e7

Comment 7

[Intermittent Failures Robot]

27 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 12
* autoland: 6
* try: 5
* mozilla-central: 4

Platform breakdown:
* linux32: 26
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1313862&startday=2016-10-31&endday=2016-11-06&tree=all