1313878 - Use lambda to create runnable for dispatching to main thread in GMPCDMCallbackProxy.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P3)

Description

[James Cheng[:JamesCheng]]

Use lambda to reduce lots of class declarations. 
Like:
  RefPtr<CDMProxy> proxy = mProxy;
  NS_DispatchToMainThread(
    NS_NewRunnableFunction([p = Move(proxy),
                            sid = NS_ConvertUTF8toUTF16(aSessionId),
                            aException,
                            aSystemCode,
                            msg = NS_ConvertUTF8toUTF16(aMessage)] ()
    {
      p->OnSessionError(sid,
                        aException,
                        aSystemCode,
                        msg);
    })
  );

But currently gecko did not fully support c++14, might cause

error: lambda capture initializers only available with -std=c++1y or -std=gnu++1y [-Werror]

So use `copy` to the capture list.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1313878 - Use lambda to create runnable for dispatching to main thread in GMPCDMCallbackProxy.cpp

Review commit: https://reviewboard.mozilla.org/r/89452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89452/

Comment 2

[James Cheng[:JamesCheng]]

Comment on attachment 8805808 [details]
Bug 1313878 - Use lambda to create runnable for dispatching to main thread in GMPCDMCallbackProxy.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89452/diff/1-2/

Comment 3

[James Cheng[:JamesCheng]]

Attach treeherder result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e026c0bbb43517e5cfcae9caabcc8aa6d0b14a44

Comment 4

[James Cheng[:JamesCheng]]

Comment on attachment 8805808 [details]
Bug 1313878 - Use lambda to create runnable for dispatching to main thread in GMPCDMCallbackProxy.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89452/diff/2-3/

Comment 5

[James Cheng[:JamesCheng]]

Attach treeherder result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d8f9c3e1f4c28890b58d92b9a82433a1299814b

Comment 6

[James Cheng[:JamesCheng]]

Comment on attachment 8805808 [details]
Bug 1313878 - Use lambda to create runnable for dispatching to main thread in GMPCDMCallbackProxy.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89452/diff/3-4/

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8805808 [details]
Bug 1313878 - Use lambda to create runnable for dispatching to main thread in GMPCDMCallbackProxy.cpp

https://reviewboard.mozilla.org/r/89452/#review88758

Comment 8

[James Cheng[:JamesCheng]]

Thanks for review.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/909d5ee27ca7
Use lambda to create runnable for dispatching to main thread in GMPCDMCallbackProxy.cpp r=cpearce

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/909d5ee27ca7