Open Bug 1313894 Opened 4 years ago Updated 1 month ago

Intermittent browser/modules/test/browser_CaptivePortalWatcher.js | Test timed out -

Categories

(Firefox :: General, defect, P5)

defect

Tracking

()

People

(Reporter: intermittent-bug-filer, Assigned: nhnt11)

References

Details

(Keywords: intermittent-failure, leave-open)

Attachments

(1 file)

Blocks: 1279491
Flags: needinfo?(nhnt11)
See Also: → 1313862
FYI, this is basically permafailing on Win8 e10s (which only runs on Try and the Ash repo since we don't have the capacity to do so for mozilla-central & integration repos).
this is now our #4 intermittent.  I saw recent activity on this test via bug 1313862, it would be nice to communicate in this bug to indicate priority and expected fix times.
I propose we disable this test on Windows for the moment, until more prioritized captive portal work has landed. (see https://public.etherpad-mozilla.org/p/captive-portal-roadmap)
Flags: needinfo?(nhnt11)
Comment on attachment 8808136 [details]
Bug 1313894 - Temporarily disable browser_CaptivePortalWatcher.js on Windows.

https://reviewboard.mozilla.org/r/91046/#review90770

::: browser/modules/test/browser.ini:10
(Diff revision 1)
>  [browser_BrowserUITelemetry_buckets.js]
>  [browser_BrowserUITelemetry_defaults.js]
>  [browser_BrowserUITelemetry_sidebar.js]
>  [browser_BrowserUITelemetry_syncedtabs.js]
>  [browser_CaptivePortalWatcher.js]
> +skip-if = os == "win" # Bug 1313894

OK, but the bug reference should point to the bug that will deal with re-enabling the test. Either mark this as leave-open or file a new bug and reference it here.
Attachment #8808136 - Flags: review?(past) → review+
(In reply to Panos Astithas [:past] from comment #9)
> Comment on attachment 8808136 [details]
> Bug 1313894 - Temporarily disable browser_CaptivePortalWatcher.js on Windows.
> 
> https://reviewboard.mozilla.org/r/91046/#review90770
> 
> ::: browser/modules/test/browser.ini:10
> (Diff revision 1)
> >  [browser_BrowserUITelemetry_buckets.js]
> >  [browser_BrowserUITelemetry_defaults.js]
> >  [browser_BrowserUITelemetry_sidebar.js]
> >  [browser_BrowserUITelemetry_syncedtabs.js]
> >  [browser_CaptivePortalWatcher.js]
> > +skip-if = os == "win" # Bug 1313894
> 
> OK, but the bug reference should point to the bug that will deal with
> re-enabling the test. Either mark this as leave-open or file a new bug and
> reference it here.

Cool, I intended to leave this open for the eventual fix. Added the flag.
Keywords: leave-open
Assignee: nobody → nhnt11
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6c1d4d2b9110
Temporarily disable browser_CaptivePortalWatcher.js on Windows. r=past
The leave-open keyword is there and there is no activity for 6 months.
:nhnt11, maybe it's time to close this bug?
Flags: needinfo?(nhnt11)

(In reply to Release mgmt bot [:sylvestre / :calixte] from comment #17)

The leave-open keyword is there and there is no activity for 6 months.
:nhnt11, maybe it's time to close this bug?

The test is still disabled on Windows, I think that keeps it open doesn't it?

Priority: -- → P5
Flags: needinfo?(nhnt11)
You need to log in before you can comment on or make changes to this bug.