1313901 - Remove some duplicated code in nsFrameLoader

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Marchesini [:baku]]

Attachment: tabContext.patch

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8805824 [details] [diff] [review]
tabContext.patch

Review of attachment 8805824 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsFrameLoader.cpp
@@ +3365,5 @@
>    attrs.mSignedPkg = NS_ConvertUTF8toUTF16(aPackageId);
>  
>    // set the userContextId on the attrs before we pass them into
>    // the tab context
> +  PopulateUserContextIdFromAttribute(attrs);

Do we need to check the return here? Looks like this can fail.

Comment 2

[Andrea Marchesini [:baku]]

Right! I've already updated the patch, but I haven't submitted the new one.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: tabContext.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2470a2feea07
Remove some duplicated code in nsFrameLoader, r=qdot

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2470a2feea07