Closed Bug 1313901 Opened 3 years ago Closed 3 years ago

Remove some duplicated code in nsFrameLoader

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch tabContext.patch (obsolete) — Splinter Review
No description provided.
Attachment #8805824 - Flags: review?(kyle)
Comment on attachment 8805824 [details] [diff] [review]
tabContext.patch

Review of attachment 8805824 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsFrameLoader.cpp
@@ +3365,5 @@
>    attrs.mSignedPkg = NS_ConvertUTF8toUTF16(aPackageId);
>  
>    // set the userContextId on the attrs before we pass them into
>    // the tab context
> +  PopulateUserContextIdFromAttribute(attrs);

Do we need to check the return here? Looks like this can fail.
Attachment #8805824 - Flags: review?(kyle) → review-
Right! I've already updated the patch, but I haven't submitted the new one.
Attached patch tabContext.patchSplinter Review
Attachment #8805824 - Attachment is obsolete: true
Attachment #8806010 - Flags: review?(kyle)
Attachment #8806010 - Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2470a2feea07
Remove some duplicated code in nsFrameLoader, r=qdot
https://hg.mozilla.org/mozilla-central/rev/2470a2feea07
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.