Closed Bug 1313965 Opened 5 years ago Closed 5 years ago

Flash Player object on cbsnews.com/48-hours/ is severely misaligned

Categories

(Web Compatibility :: Desktop, defect)

x86_64
Windows 10
defect
Not set
normal

Tracking

(firefox49 unaffected, firefox50- affected, firefox51- verified, firefox52-, firefox54 verified)

RESOLVED WORKSFORME
Tracking Status
firefox49 --- unaffected
firefox50 - affected
firefox51 - verified
firefox52 - ---
firefox54 --- verified

People

(Reporter: fehe, Assigned: karlcow)

References

()

Details

(Keywords: flashplayer, regression, Whiteboard: [webcompat])

Attachments

(3 files)

Flash Player object for videos on http://www.cbsnews.com/48-hours/ is severely misaligned.

Note: I'm using 64-bit Firefox on Windows 10

Steps to Reproduce:
1. Start Firefox with a new profile
2. Visit http://www.cbsnews.com/48-hours/
3. Play the video indicated by the blue box with "WATCH NOW" or select a different video from the "Episodes" menu
4. Note the misalignment.

I tried to find a regression window by going back as far as March; however, that seems too far, so I suspect the regression might have been introduced by Flash Player itself.

Most videos on most sites are properly aligned; however, I have encountered misalignment on some other sites too.
Michelle can your team try to narrow this down to a Flash or Firefox regression range, and try with/without the async painting pref?
Flags: needinfo?(mfunches)
QA Update:
 5:04.09 INFO: Last good revision: 28681d252003e3110105473754da2f4097cb83a6
 5:04.09 INFO: First bad revision: 806054dd12bdcbdee81dbd75f1583156cef9b649
 5:04.10 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=28681d252003e3110105473754da2f4097cb83a6&tochange=806054dd12bdcbdee81dbd75f1583156cef9b649

 5:05.60 ERROR: Unable to exploit the merge commit. Origin branch is mozilla-central, and the commit message for 806054dd was:
Merge m-c to inbound. a=merge

Tested Flash Versions 
Flash Version: 23.0.0.205 
Flash Version: 22.0.0.192 
Flash Version: 23.0.0.162 
Flash Version: 23.0.0.185
The mozregression info was tested with the latest Flash Version 23.0.0.205

Version 	49.0.2
Build ID 	20161019084923
Good regardless of asyncdrawing pref value
Flags: needinfo?(mfunches)
Bug 1307694 looks possibly-suspicious. |mozregression --repo inbound --good 4a8c5061f3b7 --bad f6811b39af13| may work for further-bisecting that range as wel.
Michelle, bug 1307694 was uplifted to 50 beta, can you verify that this regression is present there?

[Tracking Requested - why for this release]: Because I believe we uplifted this fix to 50 beta. And backing it out will cause other regressions, so I'm not yet recommending that.

Kyle, apparently a new regression in the chain of salign/attribute ordering madness :-(
Blocks: 1307694
Flags: needinfo?(kyle)
Ok. This time it's an object tag with child param tags defining scale/salign. I'll add this case to the test from bug 1307694 and see what code path I missed.
Flags: needinfo?(kyle)
BTW I think there's some weird UA specialization happening on the cbs news site. I got <object> <param>... </object> on windows nightly, but just an object tag on linux nightly, so it looks like it works there.
Attachment #8806445 - Attachment description: reduced html (for the record) → reduced html (for the record)(needs disable mixed content protection)
(In reply to Benjamin Smedberg [:bsmedberg] from comment #4)
> Michelle, bug 1307694 was uplifted to 50 beta, can you verify that this
> regression is present there?
> 
> [Tracking Requested - why for this release]: Because I believe we uplifted
> this fix to 50 beta. And backing it out will cause other regressions, so I'm
> not yet recommending that.
> 
> Kyle, apparently a new regression in the chain of salign/attribute ordering
> madness :-(

Reference attachment Bug 1307694 Notes; and let ni me if additional info is needed.
Flags: needinfo?(benjamin)
If put param "scale" before "salign" as follows, then it works on Nightly52.01,Aurora51.0a2, Beta50.0b11 and Firefox48.

    <param name="scale" value="noscale">
    <param name="salign" value="lt">

instead of
    <param name="salign" value="lt">
    <param name="scale" value="noscale">
They're using UA detection to craft param tag orders specifically for Firefox's formerly reversed parsing of params.

On chrome, scale comes before salign in the param tag order of the 48 hours page. On firefox, salign comes before scale.
ok, conclusively a webcompat issue.
Mike or cpeterson, can one of you take this to reach out to cbsnews to target their sniffing at Firefox 49 only since we will have fixed this in FF50+?
Flags: needinfo?(miket)
Flags: needinfo?(cpeterson)
Flags: needinfo?(benjamin)
(In reply to Benjamin Smedberg [:bsmedberg] from comment #13)
> ok, conclusively a webcompat issue.
> Mike or cpeterson, can one of you take this to reach out to cbsnews to
> target their sniffing at Firefox 49 only since we will have fixed this in
> FF50+?

Actually, they'll need to sniff at Firefox <= 47. The problem occurs with the reversal of tags in the parser, which happened in Fx48 (We were not re-reversing the param tags, like the issue I had to fix with dynamic node generation in bug 1307964). I just tested Fx48.0.2 and the 48 hours site is broken in it also.
FWIW, I submitted a bug report on CBS Interactive's site feedback form. I sent email to Mike and Dees about other avenues for reaching someone at CBS.

https://cbsi.secure.force.com/CBSi/sitefeedback?template=template_mobilepp
Flags: needinfo?(cpeterson)
Our team can totally help out, yeah.

Adam, do you think you'd be able to help find a good contact and do outreach here?
Flags: needinfo?(miket) → needinfo?(astevenson)
I know Karl had success with CBS Interactive in the past. Karl, can you help out with this one?
Flags: needinfo?(astevenson) → needinfo?(kdubost)
Contacted CBS about it. Adam is in cc:
Flags: needinfo?(kdubost)
Component: Plug-ins → Desktop
Product: Core → Tech Evangelism
Assignee: nobody → kdubost
Andrei could your team just double check that this is fixed in 50? Thanks.
Flags: needinfo?(andrei.vaida)
Liz, the CBS videos work in Firefox <= 49 and are broken in 50+. CBS was working around a Firefox/Flash compat issue that we fixed in 50 (bug 1307694). CBS's workaround is breaking 50+ because the workaround is no longer needed. In comment 13, Benjamin was asking for CBS to disable their workaround for 50+ but keep it for Firefox <= 47 (according to Kyle's comment 14).
Liz or Kyle, is it too late to revert our Flash fix in Beta 50? Karl has reached some people at CBS, but they are unlikely to have a fix ready when we release Firefox 50 next week.
Flags: needinfo?(lhenry)
Flags: needinfo?(kyle)
I can confirm Fx 49.0.2 (20161019084923) is unaffected.
However Fx 50.0 (20161104212021) is still affected, I verified using Windows 10 x64.
Flags: needinfo?(andrei.vaida)
Ok. This is weird. I tested in 48 and contrary to Comment 14, it's now working, which either means CBS is actually changing detection or else my test was wrong (though comment 11 makes me doubt that). Still broken in 50 though.
Flags: needinfo?(kyle)
Blocks: 1324253
Duplicate of this bug: 1324253
For the paper trail. On November 2, 2016, I received an answer from CBS

> Thanks for reporting this, Karl.  We'll take a look. 

Nothing since.
Duplicate of this bug: 1337057
Whiteboard: [webcompat]
It seems like this is still an issue, given the recent dupes.
Can confirm this is still affecting latest version of Nightly. 54.0a1 2017-02-08
Just tested this on the latest nightly build and developer build, and it looks like it has been fixed.
Thanks, Nils. I just tested 64-bit Firefox 51 and Nightly 54 and the site works for me, too.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.